Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #7270

closed

NoArtifactContentUploadViewSet should use PulpTemporaryFile instead of Artifact to store temporary data

Added by lmjachky over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
lmjachky
Category:
-
Sprint/Milestone:
3.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 81
Quarter:

Description

It was noted that the usage of the model Artifact is not considered to be a good way of storing temporary data. We do not want to keep the temporary data visible in the API during a running task.

Therefore, the method general_create_from_temp_file() (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25) needs to be refactored. The method serves the same purpose as PulpTemporaryFile was designed to. This method is used in the ViewSet NoArtifactContentUploadViewSet (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/plugin/viewsets/content.py#L91-L108), where a temporary Artifact is created on-the-fly and passed to a task.

Related issues

Related to Pulp - Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasksCLOSED - CURRENTRELEASEfao89

Actions
Actions
Send by e-mail Copy link

Also available in: Atom PDF