Refactor #7270
closed
NoArtifactContentUploadViewSet should use PulpTemporaryFile instead of Artifact to store temporary data
100%
Description
It was noted that the usage of the model Artifact is not considered to be a good way of storing temporary data. We do not want to keep the temporary data visible in the API during a running task.
Therefore, the method general_create_from_temp_file() (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25) needs to be refactored. The method serves the same purpose as PulpTemporaryFile was designed to. This method is used in the ViewSet NoArtifactContentUploadViewSet (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/plugin/viewsets/content.py#L91-L108), where a temporary Artifact is created on-the-fly and passed to a task.
Related issues
Updated by lmjachky over 4 years ago
- Related to Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasks added
Updated by fao89 over 4 years ago
- Tracker changed from Issue to Refactor
- % Done set to 0
- Severity deleted (
2. Medium) - Triaged deleted (
No) - Sprint set to Sprint 78
Updated by lmjachky over 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to lmjachky
Updated by pulpbot over 4 years ago
- Status changed from ASSIGNED to POST
Added by Lubos Mjachky about 4 years ago
Updated by Anonymous about 4 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulpcore|acbd82411fcc09bd9aba5cc5804f37f4923a22ad.
Updated by pulpbot about 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Use PulpTemporaryFile instead of Artifact when passing temporary data
closes #7270