Project

Profile

Help

Refactor #7270

Updated by lmjachky 3 months ago

It was noted that the usage of the model `Artifact` is not considered to be a good way of storing temporary data. We do not want to keep the temporary data visible in the API during a running task.

Therefore, the method general_create_from_temp_file() (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25) needs to be refactored. The method serves the same purpose as `PulpTemporaryFile` was designed to. This method is used in the ViewSet NoArtifactContentUploadViewSet (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/plugin/viewsets/content.py#L91-L108), (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25), where a temporary Artifact is created on-the-fly and passed to a task.

Back