Project

Profile

Help

Refactor #7270

closed

NoArtifactContentUploadViewSet should use PulpTemporaryFile instead of Artifact to store temporary data

Added by lmjachky about 2 years ago. Updated about 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 81
Quarter:

Description

It was noted that the usage of the model Artifact is not considered to be a good way of storing temporary data. We do not want to keep the temporary data visible in the API during a running task.

Therefore, the method general_create_from_temp_file() (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25) needs to be refactored. The method serves the same purpose as PulpTemporaryFile was designed to. This method is used in the ViewSet NoArtifactContentUploadViewSet (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/plugin/viewsets/content.py#L91-L108), where a temporary Artifact is created on-the-fly and passed to a task.


Related issues

Related to Pulp - Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasksCLOSED - CURRENTRELEASEfao89

Actions
Actions #1

Updated by lmjachky about 2 years ago

  • Related to Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasks added
Actions #2

Updated by lmjachky about 2 years ago

  • Description updated (diff)
Actions #3

Updated by fao89 about 2 years ago

  • Tracker changed from Issue to Refactor
  • % Done set to 0
  • Severity deleted (2. Medium)
  • Triaged deleted (No)
  • Sprint set to Sprint 78
Actions #4

Updated by rchan about 2 years ago

  • Sprint changed from Sprint 78 to Sprint 79
Actions #5

Updated by lmjachky about 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to lmjachky
Actions #6

Updated by pulpbot about 2 years ago

  • Status changed from ASSIGNED to POST
Actions #7

Updated by rchan about 2 years ago

  • Sprint changed from Sprint 79 to Sprint 80
Actions #8

Updated by rchan about 2 years ago

  • Sprint changed from Sprint 80 to Sprint 81

Added by Lubos Mjachky about 2 years ago

Revision acbd8241

Use PulpTemporaryFile instead of Artifact when passing temporary data

closes #7270

Actions #9

Updated by Anonymous about 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #10

Updated by bmbouter about 2 years ago

  • Sprint/Milestone set to 3.7.0
Actions #11

Updated by pulpbot about 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF