Project

Profile

Help

Send by e-mail

Refactor #7270

NoArtifactContentUploadViewSet should use PulpTemporaryFile instead of Artifact to store temporary data

Added by lmjachky 9 months ago. Updated 7 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
lmjachky
Category:
-
Sprint/Milestone:
3.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 81
Quarter:

Description

It was noted that the usage of the model Artifact is not considered to be a good way of storing temporary data. We do not want to keep the temporary data visible in the API during a running task.

Therefore, the method general_create_from_temp_file() (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/app/tasks/base.py#L6-L25) needs to be refactored. The method serves the same purpose as PulpTemporaryFile was designed to. This method is used in the ViewSet NoArtifactContentUploadViewSet (https://github.com/pulp/pulpcore/blob/212ac40f14a9925b56679346d3f0e4b4dd1417f1/pulpcore/plugin/viewsets/content.py#L91-L108), where a temporary Artifact is created on-the-fly and passed to a task.

Related issues

Related to Pulp - Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasksCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision acbd8241 View on GitHub
Added by Lubos Mjachky 7 months ago

Use PulpTemporaryFile instead of Artifact when passing temporary data

closes #7270

History

#1 Updated by lmjachky 9 months ago

  • Related to Story #6749: As a core or plugin developer, i want to be able to share temporary files between the viewset and triggered tasks added

#2 Updated by lmjachky 9 months ago

  • Description updated (diff)

#3 Updated by fao89 9 months ago

  • Tracker changed from Issue to Refactor
  • % Done set to 0
  • Severity deleted (2. Medium)
  • Triaged deleted (No)
  • Sprint set to Sprint 78

#4 Updated by rchan 8 months ago

  • Sprint changed from Sprint 78 to Sprint 79

#5 Updated by lmjachky 8 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to lmjachky

#6 Updated by pulpbot 8 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by rchan 8 months ago

  • Sprint changed from Sprint 79 to Sprint 80

#8 Updated by rchan 8 months ago

  • Sprint changed from Sprint 80 to Sprint 81

#9 Updated by Anonymous 7 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#10 Updated by bmbouter 7 months ago

  • Sprint/Milestone set to 3.7.0

#11 Updated by pulpbot 7 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Send by e-mail

Also available in: Atom PDF