Project

Profile

Help

Issue #6828

Task #6369: Allow bindings generation for views/viewsets without models/querysets

browsable API missing endpoints on /pulp/api/v3/

Added by fao89 3 months ago. Updated 3 days ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Category:
-
Start date:
Due date:
Estimated time:
(Total: 0:00 h)
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Sprint 79

Description

not all endpoints are displayed on /pulp/api/v3/ DRF issue: https://github.com/encode/django-rest-framework/issues/7354

After digging more into this, the cause is URLField from DRF, it uses django validator that introduces <! on the regex that validates the domain URLField: https://github.com/encode/django-rest-framework/blob/603aac7db10671dea1975ea3023b5488815aa1ca/rest_framework/fields.py#L885-L893 django validator: https://github.com/django/django/blob/d6aff369ad33457ae2355b5b210faf1c4890ff35/django/core/validators.py#L63-L92

We need to document to avoid URLField, and prefer CharField

example.html (1.8 MB) example.html Example of html from schema view fao89, 05/26/2020 10:31 PM

Subtasks

Ansible Plugin - Issue #6860: Replace URLField with CharFieldNEWActions

History

#1 Updated by fao89 3 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89

#2 Updated by pulpbot 3 months ago

  • Status changed from ASSIGNED to POST

#3 Updated by fao89 3 months ago

#4 Updated by fao89 2 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 74

#5 Updated by fao89 2 months ago

  • Description updated (diff)
  • Status changed from POST to NEW
  • Assignee deleted (fao89)
  • Tags Documentation added

After digging more into this, the cause is URLField from DRF, it uses django validator that introduces <! on the regex that validates the domain URLField: https://github.com/encode/django-rest-framework/blob/603aac7db10671dea1975ea3023b5488815aa1ca/rest_framework/fields.py#L885-L893 django validator: https://github.com/django/django/blob/d6aff369ad33457ae2355b5b210faf1c4890ff35/django/core/validators.py#L63-L92

We need to document to avoid URLField, and prefer CharField

#6 Updated by fao89 2 months ago

  • Description updated (diff)

#7 Updated by rchan about 2 months ago

  • Sprint changed from Sprint 74 to Sprint 75

#8 Updated by rchan about 1 month ago

  • Sprint changed from Sprint 75 to Sprint 76

#9 Updated by mdellweg about 1 month ago

This is claimed to be solved by:

https://github.com/encode/django-rest-framework/pull/7389

I think it needs to be verified, however.

#10 Updated by rchan about 1 month ago

  • Sprint changed from Sprint 76 to Sprint 77

#11 Updated by rchan 13 days ago

  • Sprint changed from Sprint 77 to Sprint 78

#12 Updated by rchan 3 days ago

  • Sprint changed from Sprint 78 to Sprint 79

Please register to edit this issue

Also available in: Atom PDF