Task #6421
closedReview of write_only fields in pulp and plugins
100%
Description
In #6346, we are trying to fix the problem where write_only fields are not showing up in the api schema. We think though that most of the use of write_only fields are unnecessary. In some cases, a serializer with write_only fields can be split in two: one for read operations and one for write operations. In other cases, write_only fields can be converted to SecretCharFields.
This task is to go through and try to eliminate write_only field usage when possible. From there we can examine which use cases still require use of write_only fields.
Related issues
Updated by daviddavis over 4 years ago
- Sprint set to Sprint 69
Adding to sprint 69 since it blocks an issue on the sprint.
Updated by daviddavis over 4 years ago
- Blocks Issue #6346: Remote fields username and password not showing up in REST docs added
Updated by mdellweg over 4 years ago
List of write_only
still in use:
pulpcore:¶
-
relative_path
on theSingleArtifactContentSerializer
OK, since there is norelative_path
in the database model. Also it is dynamically deactivated. -
dry_run
on thePulpExportSerializer
. Obviously ok, as this will not persist in the db. -
full
andversions
on thePulpExportSerializer
. Should those values be persisted? -
add/remove_content_units' on the
RepositoryAddRemoveContentSerializer`. Is this a POST-only serializer? -
file
on theUploadChunkSerializer
. OK, special case for file uploads. -
file
andrepository
on theUploadSerializerFieldsMixin
. OK, special case for file uploads and the repository being used for a non exclusive convenience association.
pulp_gem:¶
-
file
,repository
andartifact
on theGemContentSerializer
. Could use the UploadSerializerFieldsMixin. Artifact is special here.
pulp_container:¶
-
content_units
on theRecursiveManageSerializer
. Probably a POST-only serializer. -
source_repository
andsource_repository_version
on theCopySerializer
. Probably a POST-only serializer. -
containerfile
on theOCIBuildImageSerializer
. Probably a POST-only serializer.
Updated by bmbouter over 4 years ago
- Sprint/Milestone set to 3.4.0
Adding to 3.4.0 blockers list per May 19th open floor.
Updated by ggainey over 4 years ago
mdellweg wrote:
List of
write_only
still in use:pulpcore:¶
full
andversions
on thePulpExportSerializer
. Should those values be persisted?
Everything on the PulpExporter POST is persisted in the 'params' field.
Updated by dkliban@redhat.com over 4 years ago
We need to remove the write_only designation on the RepositoryAddRemoveContentSerializer serializer fields in pulpcore.
We need to remove the write_only designation on the OCIBuildImageSerializer, CopySerializer, RecursiveManageSerializer serializers in pulp_container.
Updated by daviddavis over 4 years ago
- Related to Task #6823: Remove write_only from fields that don't require it added
Updated by daviddavis over 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Updated by pulpbot over 4 years ago
- Status changed from ASSIGNED to POST
Added by daviddavis over 4 years ago
Updated by daviddavis over 4 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulpcore|89653ff81cbc5df393b1fb14583251310c3c70c0.
Updated by dkliban@redhat.com over 4 years ago
- Status changed from MODIFIED to CLOSED - COMPLETE
Remove unnecessary write_only option from RepositoryAddRemoveContentSerializer
fixes #6421