Pulp

07/02/2020

• 
  ggainey Pulp

  10:09 PM · Edited issue

  Applied in changeset commit:pulpcore|db98a55ebb67a482ae160ab1b41adc11197d499a. Issue #6919 (MODIFIED): Import/Export docs page typos

  Lots of typos on page [import-export](https://docs.pulpproject.org/en/master/nightly/workflows/import-export.html) pages.
• 
  ggainey Pulp

  10:09 PM · Committed changeset

  Also made examples consistent.
  fixes #6919 Revision db98a55e (pulpcore): Fixed a number of typos in import/export docs.
• 
  ggainey Pulp

  09:05 PM · Commented on issue

  NOTE: when preparing to merge this code, make sure to remove the additions from #7073 because we won't be touching Content explicitly any more Task #6807: Teach import/export to use 'natural keys' instead of pulp_id/uuids

  At import-time, it's not guaranteed that the 'same' entities wil have the same UUIDs (eg, "import into a post-migration-downstream"). Stop exporting pulp_ids and figure out how to take advantage of 'natural keys' (eg NEVRA for packages, ...
• 
  ggainey Pulp

  09:04 PM · Edited issue

  Applied in changeset commit:pulpcore|94cf00817669a4e7861806e85d3a252df4c16964. Issue #7073 (MODIFIED): import test fails with psycopg2.extensions.TransactionRollbackError: deadlock detected

  The test_import test is failing intermittently on Travis:...
• 
  ggainey Another option is to insure ordering on Content at export-time, by guaranteeing order at the Model level:
  ~~~ diff
  (master) ~/github/Pulp3/pulpcore $ git diff
  diff --git a/pulpcore/app/models/content.py b/pulpcore/app/models/content.p...

  03:06 AM · Commented on issue
• 
  ggainey The following diff fixes the deadlock by locking the entire table before the offending _import_file - but it is definitely a (horribly-nonperformant) "big hammer" approach. This could be generalized and moved inside _import_file() - but ...

  02:32 AM · Commented on issue
• 
  ggainey Pulp

  09:04 PM · Committed changeset

  THIS IS A TEMPORARY FIX to prevent test_pulpimport failures from
  blocking unrelated commits. See the related issue for other
  approaches.
  Success can be tested in a dev-env with the following bash cmd:
  for i in {1..10}; do
  (pytest -v ... Revision 94cf0081 (pulpcore): Prevents deadlock by locking core_content across update.

07/01/2020

• 
  ggainey Pulp

  11:04 PM · Edited issue

  Moved back to assigned since the linked PR didn't fix the prob Issue #7073 (ASSIGNED): import test fails with psycopg2.extensions.TransactionRollbackError: deadlock detected

  The test_import test is failing intermittently on Travis:...
• 
  ggainey Transaction-isolation had no impact, lots of deadlocks.
  The code in https://github.com/pulp/pulpcore/pull/745 does NOT deadlock - most likely because that change no longer explicitly import/exports core_content, which is the problem h...

  11:02 PM · Commented on issue
• 
  ggainey I forced a deadlock by running test_pulpimport in parallel :
  ~~~
  for i in {1..10}; do (pytest -v -r sx --color=yes --pyargs pulpcore.tests.functional.api.using_plugin.test_pulpimport > $i.out &); done
  ~~~
  One test failed of the...

  10:29 PM · Commented on issue