Issue #4996
closed
Ansible collection remote doesn't handle trailing / in sync url
Status:
CLOSED - CURRENTRELEASE
- Project changed from Pulp to Ansible Plugin
moving to ansible project in Redmine
We should solve this by validating the user input and checking it ends in a /.
- Status changed from NEW to ASSIGNED
- Assignee set to fao89
- Sprint set to Sprint 56
- Triaged changed from No to Yes
- Status changed from ASSIGNED to POST
- Status changed from POST to MODIFIED
- Copied to Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url added
- Subject changed from Asible collection remote doesn't handle trailing / in sync url to Ansible collection remote doesn't handle trailing / in sync url
This change added an error message for the trailing "/". Is there a reason we do not want to allow the trailing "/" ? We are going to handle this in our calls to pulp. However, wondering why it's not allowed..
Earlier in pulp_ansible sync was actually a call to the mazer client, so the URL was passed directly to mazer. If that URL contained a slash mazer would fail. This change in Pulp was a workaround to avoid this unfixed mazer issue: https://github.com/ansible/mazer/issues/288
However, after this was merged, the use of mazer (and this validation workaround) were both removed as part of https://pulp.plan.io/issues/5165 So in terms of the current state of the code this shouldn't be an issue. If you see any issues currently with trailing slashes please let us know.
- Priority changed from Normal to Low
- Tags Katello added
- Tags deleted (
Katello-P3)
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Also available in: Atom
PDF
.
validating collection remote url
closes #4996