Project

Profile

Help

Issue #4996

Ansible collection remote doesn't handle trailing / in sync url

Added by sajha 7 months ago. Updated 5 months ago.

Status:
MODIFIED
Priority:
Normal
Sprint/Milestone:
-
Start date:
Due date:
Severity:
2. Medium
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello-P3
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 56

Description


Related issues

Copied to Ansible Plugin - Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url CLOSED - COMPLETE Actions

Associated revisions

Revision 28106c26 View on GitHub
Added by Fabricio Aguiar 6 months ago

validating collection remote url

closes #4996

History

#1 Updated by bmbouter 7 months ago

  • Project changed from Pulp to Ansible Plugin

moving to ansible project in Redmine

#2 Updated by sajha 7 months ago

  • Tags Katello-P3 added

#3 Updated by daviddavis 6 months ago

We should solve this by validating the user input and checking it ends in a /.

#4 Updated by daviddavis 6 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fabricio.aguiar
  • Sprint set to Sprint 56

#5 Updated by daviddavis 6 months ago

  • Triaged changed from No to Yes

#6 Updated by fabricio.aguiar 6 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by Anonymous 6 months ago

  • Status changed from POST to MODIFIED

#8 Updated by kersom 5 months ago

  • Copied to Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url added

#9 Updated by kersom 5 months ago

  • Subject changed from Asible collection remote doesn't handle trailing / in sync url to Ansible collection remote doesn't handle trailing / in sync url

#10 Updated by sajha 5 months ago

This change added an error message for the trailing "/". Is there a reason we do not want to allow the trailing "/" ? We are going to handle this in our calls to pulp. However, wondering why it's not allowed..

#11 Updated by bmbouter 5 months ago

Earlier in pulp_ansible sync was actually a call to the mazer client, so the URL was passed directly to mazer. If that URL contained a slash mazer would fail. This change in Pulp was a workaround to avoid this unfixed mazer issue: https://github.com/ansible/mazer/issues/288

However, after this was merged, the use of mazer (and this validation workaround) were both removed as part of https://pulp.plan.io/issues/5165 So in terms of the current state of the code this shouldn't be an issue. If you see any issues currently with trailing slashes please let us know.

Please register to edit this issue

Also available in: Atom PDF