Issue #4996
closedAnsible collection remote doesn't handle trailing / in sync url
Description
Ex:
With a url https://galaxy.ansible.com it works fine.
With a url https://galaxy.ansible.com/ , throws the following error: https://gist.github.com/sjha4/0afdd783bac7cea56055b706f6b02155
Related issues
Updated by bmbouter over 5 years ago
- Project changed from Pulp to Ansible Plugin
moving to ansible project in Redmine
Updated by daviddavis over 5 years ago
We should solve this by validating the user input and checking it ends in a /
.
Updated by daviddavis over 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to fao89
- Sprint set to Sprint 56
Updated by fao89 over 5 years ago
- Status changed from ASSIGNED to POST
Added by Fabricio Aguiar over 5 years ago
Updated by Anonymous over 5 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_ansible|28106c26cc7147cd28f92a25b0d9cedb9df3ac83.
Updated by kersom over 5 years ago
- Copied to Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url added
Updated by kersom over 5 years ago
- Subject changed from Asible collection remote doesn't handle trailing / in sync url to Ansible collection remote doesn't handle trailing / in sync url
Updated by sajha about 5 years ago
This change added an error message for the trailing "/". Is there a reason we do not want to allow the trailing "/" ? We are going to handle this in our calls to pulp. However, wondering why it's not allowed..
Updated by bmbouter about 5 years ago
Earlier in pulp_ansible sync was actually a call to the mazer client, so the URL was passed directly to mazer. If that URL contained a slash mazer would fail. This change in Pulp was a workaround to avoid this unfixed mazer issue: https://github.com/ansible/mazer/issues/288
However, after this was merged, the use of mazer (and this validation workaround) were both removed as part of https://pulp.plan.io/issues/5165 So in terms of the current state of the code this shouldn't be an issue. If you see any issues currently with trailing slashes please let us know.
Updated by ggainey over 4 years ago
- Tags Katello added
- Tags deleted (
Katello-P3)
Updated by bmbouter about 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
validating collection remote url
closes #4996