Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4996

closed

Ansible collection remote doesn't handle trailing / in sync url

Added by sajha over 5 years ago. Updated about 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
fao89
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Sprint 56
Quarter:

Description

Ex:
With a url https://galaxy.ansible.com it works fine.
With a url https://galaxy.ansible.com/ , throws the following error: https://gist.github.com/sjha4/0afdd783bac7cea56055b706f6b02155

Related issues

Copied to Ansible Plugin - Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync urlCLOSED - COMPLETEActions
Actions
Copy link
 #1

Updated by bmbouter over 5 years ago

  • Project changed from Pulp to Ansible Plugin

moving to ansible project in Redmine

Actions
Copy link
 #2

Updated by sajha over 5 years ago

  • Tags Katello-P3 added
Actions
Copy link
 #3

Updated by daviddavis over 5 years ago

We should solve this by validating the user input and checking it ends in a /.

Actions
Copy link
 #4

Updated by daviddavis over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
  • Sprint set to Sprint 56
Actions
Copy link
 #5

Updated by daviddavis over 5 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #6

Updated by fao89 over 5 years ago

  • Status changed from ASSIGNED to POST

Added by Fabricio Aguiar over 5 years ago

Revision 28106c26 | View on GitHub

validating collection remote url

closes #4996

Actions
Copy link
 #7

Updated by Anonymous over 5 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #8

Updated by kersom over 5 years ago

  • Copied to Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url added
Actions
Copy link
 #9

Updated by kersom over 5 years ago

  • Subject changed from Asible collection remote doesn't handle trailing / in sync url to Ansible collection remote doesn't handle trailing / in sync url
Actions
Copy link
 #10

Updated by sajha over 5 years ago

This change added an error message for the trailing "/". Is there a reason we do not want to allow the trailing "/" ? We are going to handle this in our calls to pulp. However, wondering why it's not allowed..

Actions
Copy link
 #11

Updated by bmbouter over 5 years ago

Earlier in pulp_ansible sync was actually a call to the mazer client, so the URL was passed directly to mazer. If that URL contained a slash mazer would fail. This change in Pulp was a workaround to avoid this unfixed mazer issue: https://github.com/ansible/mazer/issues/288

However, after this was merged, the use of mazer (and this validation workaround) were both removed as part of https://pulp.plan.io/issues/5165 So in terms of the current state of the code this shouldn't be an issue. If you see any issues currently with trailing slashes please let us know.

Actions
Copy link
 #12

Updated by ggainey over 4 years ago

  • Priority changed from Normal to Low
Actions
Copy link
 #13

Updated by ggainey over 4 years ago

  • Tags Katello added
  • Tags deleted (Katello-P3)
Actions
Copy link
 #14

Updated by bmbouter about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF