Project

Profile

Help

Issue #4996

Ansible collection remote doesn't handle trailing / in sync url

Added by sajha over 1 year ago. Updated 2 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Sprint 56
Quarter:

Description


Related issues

Copied to Ansible Plugin - Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync urlCLOSED - COMPLETE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 28106c26 View on GitHub
Added by Fabricio Aguiar over 1 year ago

validating collection remote url

closes #4996

History

#1 Updated by bmbouter over 1 year ago

  • Project changed from Pulp to Ansible Plugin

moving to ansible project in Redmine

#2 Updated by sajha over 1 year ago

  • Tags Katello-P3 added

#3 Updated by daviddavis over 1 year ago

We should solve this by validating the user input and checking it ends in a /.

#4 Updated by daviddavis over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
  • Sprint set to Sprint 56

#5 Updated by daviddavis over 1 year ago

  • Triaged changed from No to Yes

#6 Updated by fao89 over 1 year ago

  • Status changed from ASSIGNED to POST

#7 Updated by Anonymous over 1 year ago

  • Status changed from POST to MODIFIED

#8 Updated by kersom over 1 year ago

  • Copied to Test #5256: Test - Ansible collection remote doesn't handle trailing / in sync url added

#9 Updated by kersom over 1 year ago

  • Subject changed from Asible collection remote doesn't handle trailing / in sync url to Ansible collection remote doesn't handle trailing / in sync url

#10 Updated by sajha over 1 year ago

This change added an error message for the trailing "/". Is there a reason we do not want to allow the trailing "/" ? We are going to handle this in our calls to pulp. However, wondering why it's not allowed..

#11 Updated by bmbouter over 1 year ago

Earlier in pulp_ansible sync was actually a call to the mazer client, so the URL was passed directly to mazer. If that URL contained a slash mazer would fail. This change in Pulp was a workaround to avoid this unfixed mazer issue: https://github.com/ansible/mazer/issues/288

However, after this was merged, the use of mazer (and this validation workaround) were both removed as part of https://pulp.plan.io/issues/5165 So in terms of the current state of the code this shouldn't be an issue. If you see any issues currently with trailing slashes please let us know.

#12 Updated by ggainey 7 months ago

  • Priority changed from Normal to Low

#13 Updated by ggainey 7 months ago

  • Tags Katello added
  • Tags deleted (Katello-P3)

#14 Updated by bmbouter 2 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF