Task #4714
closed
Remove the 'validate' field from Master Remote object
100%
Description
The 'validate' field should be removed.
Our Master Remote includes fields that it shouldn't. In our original planning, the fields that were included seem to be "all fields that many plugins will probably need". This sends a mixed message to plugin authors, who may not be familiar with how or if these fields are used at all by pulpcore.
`validate. The pulpcore provided downloaders do some validation, but are unaware of the Remote.validate value. If this field is used, it must be used by the plugin. Therefore, the plugin should be the one to add it if they want it.
Updated by amacdona@redhat.com over 5 years ago
To expand on this, some of these fields could be semi-implemented by pulpcore. For instance, policy should not be included on the remote, but policy choices should be defined by pulpcore and set on the plugin remote if they decide to have a policy field.
Updated by dkliban@redhat.com over 5 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
Updated by amacdona@redhat.com over 5 years ago
This should be considered a "backwards incompatible" change and should be included in a pulpcore-plugin release with with a version bump (not just an rc bump).
Updated by amacdona@redhat.com over 5 years ago
- Sprint changed from Sprint 53 to Sprint 54
Updated by bmbouter over 5 years ago
- Subject changed from Remove extra fields from Master Remote object to Remove the 'validate' field from Master Remote object
- Description updated (diff)
Rewriting to remove mention of 'policy' which is being fixed with https://pulp.plan.io/issues/4990 instead.
Updated by amacdona@redhat.com over 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to amacdona@redhat.com
Updated by amacdona@redhat.com over 5 years ago
- Status changed from ASSIGNED to POST
Added by amacdona@redhat.com over 5 years ago
Added by amacdona@redhat.com over 5 years ago
Revision 9e6e5d36 | View on GitHub
Remove unused field Remote.validate
This field was intended for plugin use, but so far plugins validate unconditionally. For now, we remove the field from core but plugins can add it on their own if they have a use for it.
Updated by amacdona@redhat.com over 5 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulpcore|9e6e5d36e594ffff85aac0dc28aa77e06874b971.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Remove validate field (no longer exists in core)
Required PR: https://github.com/pulp/pulpcore/pull/194
https://pulp.plan.io/issues/4714 re #4714