Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4253

closed

modules.yaml reference in repomd.xml does not use selected checksum

Added by jsherril@redhat.com about 6 years ago. Updated over 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
dalley
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.17.0
Platform Release:
2.18.1
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Sprint 47
Quarter:

Description

A report from upstream katello (https://projects.theforeman.org/issues/25529) indicates that pulp generates a repomd.xml file that claims to use the checksum type that has been set on the publisher, but in fact is not using that:

In this example it purports to have used a sha1 checksum, but in fact its actually a sha256 checksum:

  <data type="modules">
    <location href="repodata/824ffe238f202a0612ecbb2b0c0459dc289a7ef47adb1f26406453d41f476449-modules.yaml.gz"/>
    <timestamp>1542811864</timestamp>
    <size>33</size>
    <checksum type="sha1">824ffe238f202a0612ecbb2b0c0459dc289a7ef47adb1f26406453d41f476449</checksum>
    <open-size>0</open-size>
    <open-checksum type="sha1">da39a3ee5e6b4b0d3255bfef95601890afd80709</open-checksum>
  </data>

To reproduce:

1. create and sync a yum repository
2. set a checksum type of sha1
3. publish the repository

Related issues

Has duplicate RPM Support - Issue #4335: DNF can't handle empty modules.yaml.gzCLOSED - DUPLICATEActions
Copied to RPM Support - Test #4351: modules.yaml reference in repomd.xml does not use selected checksumCLOSED - COMPLETEragbalakActions
Actions
Copy link
 #1

Updated by jsherril@redhat.com about 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by ttereshc about 6 years ago

The checksum type is set correctly.
During publish of module.yaml repodata, sha256 checksum is always calculated. The correct checksum type can be found this way.

Actions
Copy link
 #3

Updated by CodeHeeler about 6 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 46
  • Tags Easy Fix added
Actions
Copy link
 #4

Updated by rchan almost 6 years ago

  • Sprint changed from Sprint 46 to Sprint 47
Actions
Copy link
 #5

Updated by dalley almost 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
Actions
Copy link
 #6

Updated by dalley almost 6 years ago

  • Status changed from ASSIGNED to POST

Added by dalley almost 6 years ago

Revision a6a8e5de | View on GitHub

Fix bugs related to modularity

Ensure we don't publish module metadata files for repositories where the source repo had none.

Use the correct mechanism for determining the checksum used in the name of the modules.yaml.gz metadata file.

Additionally, refactor the module publish step to be more similar to the others.

closes #4252 https://pulp.plan.io/issues/4252 closes #4253 https://pulp.plan.io/issues/4253

Actions
Copy link
 #7

Updated by dalley almost 6 years ago

  • Status changed from POST to MODIFIED
  • Platform Release set to 2.18.1
Actions
Copy link
 #8

Updated by dalley almost 6 years ago

Actions
Copy link
 #9

Updated by dalley almost 6 years ago

  • Has duplicate Issue #4335: DNF can't handle empty modules.yaml.gz added

Added by dalley almost 6 years ago

Revision 7835e11b | View on GitHub

Fix bugs related to modularity

Ensure we don't publish module metadata files for repositories where the source repo had none.

Use the correct mechanism for determining the checksum used in the name of the modules.yaml.gz metadata file.

Additionally, refactor the module publish step to be more similar to the others.

closes #4252 https://pulp.plan.io/issues/4252 closes #4253 https://pulp.plan.io/issues/4253

Actions
Copy link
 #10

Updated by bherring almost 6 years ago

  • Copied to Test #4351: modules.yaml reference in repomd.xml does not use selected checksum added
Actions
Copy link
 #11

Updated by dalley almost 6 years ago

Actions
Copy link
 #12

Updated by jortel@redhat.com almost 6 years ago

  • Status changed from MODIFIED to 5
Actions
Copy link
 #13

Updated by jortel@redhat.com almost 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions
Copy link
 #14

Updated by bmbouter over 5 years ago

  • Tags Pulp 2 added
Actions
Send by e-mail Copy link

Also available in: Atom PDF