Project

Profile

Help

Issue #4253

modules.yaml reference in repomd.xml does not use selected checksum

Added by jsherril@redhat.com 6 months ago. Updated 2 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Severity:
2. Medium
Version:
2.17.0
Platform Release:
2.18.1
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 47

Description

A report from upstream katello (https://projects.theforeman.org/issues/25529) indicates that pulp generates a repomd.xml file that claims to use the checksum type that has been set on the publisher, but in fact is not using that:

In this example it purports to have used a sha1 checksum, but in fact its actually a sha256 checksum:

  <data type="modules">
    <location href="repodata/824ffe238f202a0612ecbb2b0c0459dc289a7ef47adb1f26406453d41f476449-modules.yaml.gz"/>
    <timestamp>1542811864</timestamp>
    <size>33</size>
    <checksum type="sha1">824ffe238f202a0612ecbb2b0c0459dc289a7ef47adb1f26406453d41f476449</checksum>
    <open-size>0</open-size>
    <open-checksum type="sha1">da39a3ee5e6b4b0d3255bfef95601890afd80709</open-checksum>
  </data>

To reproduce:

1. create and sync a yum repository
2. set a checksum type of sha1
3. publish the repository


Related issues

Duplicated by RPM Support - Issue #4335: DNF can't handle empty modules.yaml.gz CLOSED - DUPLICATE Actions
Copied to RPM Support - Test #4351: modules.yaml reference in repomd.xml does not use selected checksum CLOSED - COMPLETE Actions

Associated revisions

Revision a6a8e5de View on GitHub
Added by dalley 5 months ago

Fix bugs related to modularity

Ensure we don't publish module metadata files for repositories where the source repo had none.

Use the correct mechanism for determining the checksum used in the name
of the modules.yaml.gz metadata file.

Additionally, refactor the module publish step to be more similar to the
others.

closes #4252
https://pulp.plan.io/issues/4252
closes #4253
https://pulp.plan.io/issues/4253

Revision 7835e11b View on GitHub
Added by dalley 5 months ago

Fix bugs related to modularity

Ensure we don't publish module metadata files for repositories where the source repo had none.

Use the correct mechanism for determining the checksum used in the name
of the modules.yaml.gz metadata file.

Additionally, refactor the module publish step to be more similar to the
others.

closes #4252
https://pulp.plan.io/issues/4252
closes #4253
https://pulp.plan.io/issues/4253

History

#1 Updated by jsherril@redhat.com 6 months ago

  • Description updated (diff)

#2 Updated by ttereshc 6 months ago

The checksum type is set correctly.
During publish of module.yaml repodata, sha256 checksum is always calculated. The correct checksum type can be found this way.

#3 Updated by CodeHeeler 6 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 46
  • Tags Easy Fix added

#4 Updated by rchan 6 months ago

  • Sprint changed from Sprint 46 to Sprint 47

#5 Updated by dalley 5 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley

#6 Updated by dalley 5 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by dalley 5 months ago

  • Status changed from POST to MODIFIED
  • Platform Release set to 2.18.1

#8 Updated by dalley 5 months ago

#9 Updated by dalley 5 months ago

  • Duplicated by Issue #4335: DNF can't handle empty modules.yaml.gz added

#10 Updated by bherring 5 months ago

  • Copied to Test #4351: modules.yaml reference in repomd.xml does not use selected checksum added

#11 Updated by dalley 5 months ago

#12 Updated by jortel@redhat.com 4 months ago

  • Status changed from MODIFIED to ON_QA

#13 Updated by jortel@redhat.com 4 months ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

#14 Updated by bmbouter 2 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF