Actions
Issue #4245
closedOur build environment should not use the editable option when pip installing packages
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 58
Quarter:
Description
Bruno pointed out that in Travis we install packages like pulpcore and pulpcore-plugin using pip install -e ...
. This symlinks the package into place and doesn't actually build it.
Consider the case where we have a file that we want to ship with the package (e.g. "blah"). It might not be getting properly included in the built package but using pip install -e ...
would mask this problem.
Updated by CodeHeeler over 5 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 46
Updated by daviddavis over 5 years ago
Note that plugins also suffer from this problem.
Updated by dkliban@redhat.com over 5 years ago
- Status changed from NEW to ASSIGNED
Updated by ipanova@redhat.com over 5 years ago
- Assignee set to dkliban@redhat.com
Updated by dkliban@redhat.com over 5 years ago
- Status changed from ASSIGNED to NEW
- Assignee deleted (
dkliban@redhat.com)
Updated by ppicka about 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ppicka
Updated by ppicka about 5 years ago
- Status changed from ASSIGNED to POST
- Tags deleted (
Easy Fix)
PR: https://github.com/pulp/pulpcore/pull/144 which required PR https://github.com/pulp/pulp-certguard/pull/22
Updated by amacdona@redhat.com about 5 years ago
- Sprint changed from Sprint 53 to Sprint 54
Updated by ttereshc about 5 years ago
- Sprint changed from Sprint 54 to Sprint 55
Updated by dkliban@redhat.com about 5 years ago
- Sprint changed from Sprint 55 to Sprint 56
Updated by ppicka almost 5 years ago
- Status changed from POST to CLOSED - WONTFIX
Since this issue was file pulp installation was changed so this not issue anymore.
PR closed as well.
Added by ppicka over 4 years ago
Actions
Include test files
add test files as certificate and scripts used with test to MANIFEST.in as when installed without pip editable option 'pip install -e' it is not packaged
re: #4245 https://pulp.plan.io/issues/4245
Signed-off-by: Pavel Picka ppicka@redhat.com