Issue #4245
Our build environment should not use the editable option when pip installing packages
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 58
Quarter:
Description
Bruno pointed out that in Travis we install packages like pulpcore and pulpcore-plugin using pip install -e ...
. This symlinks the package into place and doesn't actually build it.
Consider the case where we have a file that we want to ship with the package (e.g. "blah"). It might not be getting properly included in the built package but using pip install -e ...
would mask this problem.
Associated revisions
History
#1
Updated by daviddavis about 2 years ago
- Description updated (diff)
#2
Updated by daviddavis about 2 years ago
- Tags Easy Fix added
#3
Updated by CodeHeeler about 2 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 46
#4
Updated by daviddavis about 2 years ago
Note that plugins also suffer from this problem.
#5
Updated by dkliban@redhat.com about 2 years ago
- Status changed from NEW to ASSIGNED
#6
Updated by ipanova@redhat.com about 2 years ago
- Assignee set to dkliban@redhat.com
#7
Updated by rchan about 2 years ago
- Sprint changed from Sprint 46 to Sprint 47
#8
Updated by rchan about 2 years ago
- Sprint changed from Sprint 47 to Sprint 48
#9
Updated by rchan almost 2 years ago
- Sprint changed from Sprint 48 to Sprint 49
#10
Updated by rchan almost 2 years ago
- Sprint changed from Sprint 49 to Sprint 50
#11
Updated by rchan almost 2 years ago
- Sprint changed from Sprint 50 to Sprint 51
#12
Updated by rchan almost 2 years ago
- Sprint changed from Sprint 51 to Sprint 52
#13
Updated by daviddavis almost 2 years ago
- Sprint/Milestone set to 3.0.0
#14
Updated by bmbouter almost 2 years ago
- Tags deleted (
Pulp 3)
#15
Updated by dkliban@redhat.com over 1 year ago
- Status changed from ASSIGNED to NEW
- Assignee deleted (
dkliban@redhat.com)
#16
Updated by rchan over 1 year ago
- Sprint changed from Sprint 52 to Sprint 53
#17
Updated by ppicka over 1 year ago
- Status changed from NEW to ASSIGNED
- Assignee set to ppicka
#18
Updated by ppicka over 1 year ago
- Status changed from ASSIGNED to POST
- Tags deleted (
Easy Fix)
PR: https://github.com/pulp/pulpcore/pull/144 which required PR https://github.com/pulp/pulp-certguard/pull/22
#19
Updated by amacdona@redhat.com over 1 year ago
- Sprint changed from Sprint 53 to Sprint 54
#20
Updated by ttereshc over 1 year ago
- Sprint changed from Sprint 54 to Sprint 55
#21
Updated by dkliban@redhat.com over 1 year ago
- Sprint changed from Sprint 55 to Sprint 56
#22
Updated by rchan over 1 year ago
- Sprint changed from Sprint 56 to Sprint 57
#23
Updated by rchan over 1 year ago
- Sprint changed from Sprint 57 to Sprint 58
#24
Updated by ppicka over 1 year ago
- Status changed from POST to CLOSED - WONTFIX
Since this issue was file pulp installation was changed so this not issue anymore.
PR closed as well.
Please register to edit this issue
Include test files
add test files as certificate and scripts used with test to MANIFEST.in as when installed without pip editable option 'pip install -e' it is not packaged
re: #4245 https://pulp.plan.io/issues/4245
Signed-off-by: Pavel Picka ppicka@redhat.com