Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4245

closed

Our build environment should not use the editable option when pip installing packages

Added by daviddavis almost 6 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
ppicka
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 58
Quarter:

Description

Bruno pointed out that in Travis we install packages like pulpcore and pulpcore-plugin using pip install -e .... This symlinks the package into place and doesn't actually build it.

Consider the case where we have a file that we want to ship with the package (e.g. "blah"). It might not be getting properly included in the built package but using pip install -e ... would mask this problem.

Actions
Copy link
 #1

Updated by daviddavis almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by daviddavis almost 6 years ago

  • Tags Easy Fix added
Actions
Copy link
 #3

Updated by CodeHeeler almost 6 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 46
Actions
Copy link
 #4

Updated by daviddavis almost 6 years ago

Note that plugins also suffer from this problem.

Actions
Copy link
 #5

Updated by dkliban@redhat.com almost 6 years ago

  • Status changed from NEW to ASSIGNED
Actions
Copy link
 #6

Updated by ipanova@redhat.com almost 6 years ago

  • Assignee set to dkliban@redhat.com
Actions
Copy link
 #7

Updated by rchan almost 6 years ago

  • Sprint changed from Sprint 46 to Sprint 47
Actions
Copy link
 #8

Updated by rchan almost 6 years ago

  • Sprint changed from Sprint 47 to Sprint 48
Actions
Copy link
 #9

Updated by rchan almost 6 years ago

  • Sprint changed from Sprint 48 to Sprint 49
Actions
Copy link
 #10

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 49 to Sprint 50
Actions
Copy link
 #11

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 50 to Sprint 51
Actions
Copy link
 #12

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 51 to Sprint 52
Actions
Copy link
 #13

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #14

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #15

Updated by dkliban@redhat.com over 5 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (dkliban@redhat.com)
Actions
Copy link
 #16

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 52 to Sprint 53
Actions
Copy link
 #17

Updated by ppicka over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions
Copy link
 #18

Updated by ppicka over 5 years ago

  • Status changed from ASSIGNED to POST
  • Tags deleted (Easy Fix)
Actions
Copy link
 #19

Updated by amacdona@redhat.com over 5 years ago

  • Sprint changed from Sprint 53 to Sprint 54
Actions
Copy link
 #20

Updated by ttereshc over 5 years ago

  • Sprint changed from Sprint 54 to Sprint 55
Actions
Copy link
 #21

Updated by dkliban@redhat.com over 5 years ago

  • Sprint changed from Sprint 55 to Sprint 56
Actions
Copy link
 #22

Updated by rchan about 5 years ago

  • Sprint changed from Sprint 56 to Sprint 57
Actions
Copy link
 #23

Updated by rchan about 5 years ago

  • Sprint changed from Sprint 57 to Sprint 58
Actions
Copy link
 #24

Updated by ppicka about 5 years ago

  • Status changed from POST to CLOSED - WONTFIX

Since this issue was file pulp installation was changed so this not issue anymore.
PR closed as well.

Added by ppicka almost 5 years ago

Revision 90cc983d | View on GitHub

Include test files

add test files as certificate and scripts used with test to MANIFEST.in as when installed without pip editable option 'pip install -e' it is not packaged

re: #4245 https://pulp.plan.io/issues/4245

Signed-off-by: Pavel Picka

Actions
Send by e-mail Copy link

Also available in: Atom PDF