Tests in master are failing due to a change in pulp_file
A recent change in pulp_file0 has caused the tests in pulp to fail. The issue is that tests in pulp are coupled to the pulp_file plugin code1 and we're not running pulpcore tests against pulp_file. So any changes to pulp_file could unknowingly break the tests in pulpcore.
The purist in me thinks that we should not have the tests in pulpcore be dependent on the code in pulp_file and that these tests should be moved to pulp_file. We're running the pulp_file tests against all pulpcore PRs anyway so moving them wouldn't hurt.
The simplest option however would be to fix these tests and then run the pulpcore tests against pulp_file PRs. That feels kind of wrong but it's quick and easy.
The third and final option I can think of (and I'm not totally sure how this would work) is to create a bare/mock plugin inside the test framework and have the pulpcore smash tests use it for tests that require a plugin and content units.
#9 Updated by email@example.com about 1 year ago
Short term, I agree with fixing the tests.
Long term, I think having core tests rely on the file plugin is undesirable as demonstrated by this incident. I don't think having a test (mock) plugin in core code tree is a good idea. However, including a TestPlugin in the pulpcore/tests/functional code tree seems reasonable.
#11 Updated by kersom about 1 year ago
Based on the previous comments, I think that if certain core feature requires a plugin in order to be tested this test should live inside the plugin repository, and not be part of the core repository.
Besides that, if possible we should use one plugin to test all the core features that require a plugin. Or at least, most of the features.
#12 Updated by daviddavis about 1 year ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_file:f3fad23f1a024682391f2a92b182282da6448977.
Please register to edit this issue