https://pulp.plan.io/https://pulp.plan.io/favicon.ico2018-09-11T22:31:24ZPulpPulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306822018-09-11T22:31:24Zdaviddavis
<ul></ul><p>This is causing all PRs against the Pulp master branch to fail so I'm setting the severity to high.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306832018-09-11T22:33:59Zdaviddavis
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/30683/diff?detail_id=31459">diff</a>)</li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306842018-09-11T22:37:00Zdaviddavis
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/30684/diff?detail_id=31460">diff</a>)</li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306852018-09-11T22:38:08Zdaviddavis
<ul><li><strong>Subject</strong> changed from <i>Tests in master are failing</i> to <i>Tests in master are failing due to a change in pulp_file</i></li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306902018-09-12T13:44:17Zdalleydalley@redhat.com
<ul></ul><p>Long-term, I'm neutral on a mock plugin. Short-term, we should keep the tests in pulpcore, and we should run the "using_plugin" tests in pulpcore along w/ pulp_file.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306912018-09-12T13:54:37Zdaviddavis
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-11 priority-6 priority-default closed" href="/issues/3912">Story #3912</a>: As a user, I can specify the file manifest name on the remote when syncing and publishing a repository</i> added</li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306932018-09-12T13:55:59Zdaviddavis
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-11 priority-6 priority-default closed" href="/issues/3913">Story #3913</a>: As a user I can specify the manifest filename when publishing a repo version</i> added</li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306952018-09-12T14:01:33Zdaviddavis
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>POST</i></li><li><strong>Assignee</strong> set to <i>daviddavis</i></li></ul><p><a href="https://github.com/pulp/pulp/pull/3627" class="external">https://github.com/pulp/pulp/pull/3627</a><br>
<a href="https://github.com/pulp/pulp_file/pull/118" class="external">https://github.com/pulp/pulp_file/pull/118</a></p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=306992018-09-12T14:21:56Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>Short term, I agree with fixing the tests.</p>
<p>Long term, I think having core tests rely on the file plugin is undesirable as demonstrated by this incident. I don't think having a test (<em>mock</em>) plugin in core code tree is a good idea. However, including a <em>TestPlugin</em> in the pulpcore/tests/functional code tree seems reasonable.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=307022018-09-12T14:42:06Zdaviddavis
<ul></ul><p>Cool, thanks for the feedback <a class="user active" href="https://pulp.plan.io/users/349">dalley</a> and @jortel. I will use this bug to fix the tests.</p>
<p>I've opened a separate issue to continue discussions around using a test plugin: <a href="https://pulp.plan.io/issues/4003" class="external">https://pulp.plan.io/issues/4003</a>.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=307052018-09-12T14:51:24Zkersom
<ul></ul><p>Based on the previous comments, I think that if certain core feature requires a plugin in order to be tested this test should live inside the plugin repository, and not be part of the core repository.</p>
<p>Besides that, if possible we should use one plugin to test all the core features that require a plugin. Or at least, most of the features.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=307142018-09-12T21:08:16Zdaviddavis
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Run pulpcore functional tests as part of the Travis job Since pulpcore functional tests use pulp..." href="https://pulp.plan.io/projects/pulp_file/repository/38/revisions/f3fad23f1a024682391f2a92b182282da6448977">pulp_file:f3fad23f1a024682391f2a92b182282da6448977</a>.</p> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=413162019-04-25T16:44:51Zdaviddavis
<ul><li><strong>Sprint/Milestone</strong> set to <i>3.0.0</i></li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=423382019-04-26T20:34:08Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>Pulp 3</i></del>)</li></ul> Pulp - Issue #4000: Tests in master are failing due to a change in pulp_filehttps://pulp.plan.io/issues/4000?journal_id=512592019-12-13T17:33:47Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul>