Project

Profile

Help

Issue #4000

Updated by daviddavis about 2 years ago

A recent change in pulp_file[0] has caused the tests in pulp to fail. The issue is that tests in pulp are coupled to the pulp_file plugin code[1] and we're not running pulpcore tests against pulp_file. So any changes to pulp_file could unknowingly break the tests in pulpcore.

The purist in me thinks that we should not have the tests in pulpcore be dependent on the code in pulp_file and that these tests should be moved to pulp_file. We're running the pulp_file tests against all pulpcore PRs anyway so moving them wouldn't hurt.

The simplest option however would be to fix these tests and then run the pulpcore tests against pulp_file PRs. That feels kind of wrong but it's quick and easy.

The third and final option I can think of (and I'm not totally sure how this would work) is to create a bare/mock plugin inside the test framework and have the pulpcore smash tests use it for tests that require a plugin and content units.

[0] https://github.com/pulp/pulp_file/pull/115
[1] https://github.com/pulp/pulp/tree/master/pulpcore/tests/functional/api/using_plugin

Back