Issue #3521
closed
last_override_config exposes sensitive info
Description
Importers and distributors have a "last_override_config" object which is exposed via the API.
In several cases, secrets are passed into override_config when triggering a task. For example, in yum importer there's ssl_client_key and in docker importer there's basic_auth_password. If these config items are given, they're stored in last_override_config and then become readable to all users with read access on the distributor/importer.
This makes usage of those config items quite dangerous as one can't pass these secrets into the API for a sync without also considering which users have read access on the objects, and whether it's OK to expose the secret to those users. Or more likely, one would fail to consider this, and thus would build tools/workflows which expose the secrets without realizing it.
That latter scenario is exactly what I'm faced with now, because it has always been established procedure that our Pulp installations internally have widely shared read-only accounts, allowing everyone to freely data mine / build applications on top of our Pulp without administrative hassle. Due to realization of this issue, that's now under threat and we may be forced to make the system less convenient.
Solution:
- Keep the secrets in the DB but don't render them in the API
Related issues
Updated by bmbouter over 6 years ago
+1 to keeping the options in the db and not rendering them in the API. What if we add a new option that allows the sensitive keys to be listed by the user. Then the API just hides those.
Updated by kseifried@redhat.com over 6 years ago
This has been assigned CVE-2018-1090, can we make this public? Thanks.
Updated by bmbouter over 6 years ago
- Private changed from Yes to No
I'm +1 on making it public as were all other devs in chat earlier. I'm making that change now per @kurt's recommendation.
Also it would be great if we could get a fix contributed that allows the user to hide the credentials that are displayed.
Updated by dalley over 6 years ago
- Triaged changed from No to Yes
- Sprint Candidate changed from No to Yes
Updated by ttereshc over 6 years ago
+1 for - Keep the secrets in the DB but don't render them in the API
Updated by ttereshc over 6 years ago
- Description updated (diff)
- Groomed changed from No to Yes
Updated by bmbouter over 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bmbouter
Updated by bmbouter over 6 years ago
- Status changed from ASSIGNED to POST
PR available at: https://github.com/pulp/pulp/pull/3513
Added by bmbouter over 6 years ago
Updated by bmbouter over 6 years ago
I could reproduce easily by starting with the default zoo repo from pulp-admin. Then I caused a sync with an override specified:
curl --insecure -X POST --user admin:admin -d '{"override_config": {"feed": "https://example.com"}}' https://localhost/pulp/api/v2/repositories/zoo/actions/sync/
Then without the patch applied I show the serialized importer which shows the data in last_override_config:
curl --insecure -X GET --user admin:admin https://localhost/pulp/api/v2/repositories/zoo/importers/yum_importer/ | jq
{
"repo_id": "zoo",
"last_updated": "2018-06-01T18:44:02Z",
"_href": "/pulp/api/v2/repositories/zoo/importers/yum_importer/",
"_ns": "repo_importers",
"importer_type_id": "yum_importer",
"last_override_config": {
"feed": "https://example.com"
},
"last_sync": "2018-06-01T20:10:02Z",
"scratchpad": {
"repomd_revision": 1331832478
},
"_id": {
"$oid": "5b1193f230f252206fea660d"
},
"config": {
"feed": "https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/zoo/"
},
"id": "yum_importer"
}
Then applying the patch the output now looks like:
curl --insecure -X GET --user admin:admin https://localhost/pulp/api/v2/repositories/zoo/importers/yum_importer/ | jq
{
"repo_id": "zoo",
"last_updated": "2018-06-01T18:44:02Z",
"_href": "/pulp/api/v2/repositories/zoo/importers/yum_importer/",
"_ns": "repo_importers",
"importer_type_id": "yum_importer",
"last_override_config": {},
"last_sync": "2018-06-01T20:10:02Z",
"scratchpad": {
"repomd_revision": 1331832478
},
"_id": {
"$oid": "5b1193f230f252206fea660d"
},
"config": {
"feed": "https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/zoo/"
},
"id": "yum_importer"
}
Updated by bmbouter over 6 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|9c776506a1fdbd70fc95547516288f549b80ccbf.
Added by bmbouter over 6 years ago
Revision 723672e3 | View on GitHub
Redact last_override_config
This commit resolvs CVE-2018-1090 by redacting all data from last_override_config. It does not modify what is saved in the database. It also adds a release note for the 2.16.2 release.
https://pulp.plan.io/issues/3521 closes #3521
(cherry picked from commit 9c776506a1fdbd70fc95547516288f549b80ccbf)
Updated by bmbouter over 6 years ago
Applied in changeset pulp|723672e315bbdd096801943c2c787fcf889b7523.
Updated by Ichimonji10 over 6 years ago
Updated by bmbouter about 6 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
I'm not sure why this is not at MODIFIED, but from the associated commits (links also below), I can see the code lives on the 2.16-release, 2.17-release, and 2-master so I'm moving to CLOSED - CURRENTRELEASE.
https://github.com/pulp/pulp/commit/9c776506a1fdbd70fc95547516288f549b80ccbf
https://github.com/pulp/pulp/commit/723672e315bbdd096801943c2c787fcf889b7523
Updated by daviddavis about 6 years ago
- Related to Issue #4083: Non-sensitive information is not being displayed for last_override_config added
.
Redact last_override_config
This commit resolvs CVE-2018-1090 by redacting all data from last_override_config. It does not modify what is saved in the database. It also adds a release note for the 2.16.2 release.
https://pulp.plan.io/issues/3521 closes #3521