Issue #3016: Removal of an Artifact leaves repo with associated artifactless Content forever - Pulp

Send by e-mail

Issue #3016

Removal of an Artifact leaves repo with associated artifactless Content forever

Added by ttereshc over 2 years ago. Updated 3 months ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

High

Assignee:

ttereshc

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Severity:

3. High

Version:

Platform Release:

Blocks Release:

OS:

Backwards Incompatible:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

QA Contact:

Complexity:

Smash Test:

Verified:

Verification Required:

Sprint:

Sprint 29

Description

Steps to reproduce:

create repo
create importer with immediate policy
sync
remove Artifact by its id, e.g. http://127.0.0.1:8000/api/v3/artifacts/0585cddf-0782-47b2-886b-ba08d2cad163/

Observe no records in pulp_app_artifact, pulp_app_contentartifact, pulp_app_remoteartifact for the deleted Artifact (because of ON_CASCADE delete).
All the Content-related tables stay untouched => repository claims to have all the content.
Key attributes of deleted Artifact are left in pulp_file_filecontent (path and digest).

I don't think that importer is expected to recover from this state with a subsequent sync (e.g. RemoreArtifact doesn't exist for the deleted Artifact, so if this content no longer exists in the upstream repo + sync mode is additive, this artifactless Content will remain in repo.

Workaround: explicitly delete related Content.

Associated revisions

Revision 4f896e25 View on GitHub
Added by ttereshc about 2 years ago

Delete an Artifact only if it is not associated with any Content

closes #3016 https://pulp.plan.io/issues/3016

Revision 4f896e25 View on GitHub
Added by ttereshc about 2 years ago

Delete an Artifact only if it is not associated with any Content

closes #3016 https://pulp.plan.io/issues/3016

History

#1 Updated by dkliban@redhat.com over 2 years ago

Did you remove teh Artifact using REST API or directly in the database?

I don't think we want to allow the REST API for deleting Artifacts to support deletion of an Artifact if it belongs to Content that is associated with a repository.