Project

Profile

Help

Story #8881

As a user, Pulp will retry downloads by default 5 times and I can configure this value on my Remote

Added by bmbouter 4 days ago. Updated about 9 hours ago.

Status:
POST
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Quarter:

Description

Background

Currently Pulp will only retry on specific http error codes:

429 - Too Many Requests 502 - Bad Gateway 503 - Service Unavailable 504 - Gateway Timeout

That happens here: https://github.com/pulp/pulpcore/blob/master/pulpcore/download/http.py#L15-L32

The need to retry

  1. It's expected by users. Almost all (if not all) download tools, e.g. curl, wget, etc have retry behaviors in them
  2. With sync having so many downloads occur and a single error halting the entire process, as it is now, Pulp is not very reliable

What to retry on

With the implementation of this feature Pulp will retry in the following situations:

  • All HTTP 5xx response codes
  • HTTP 429
  • Socket timeouts and TCP disconnects

This is a simplified set of cases that mimics the retry behaviors outlined by AWS and Google Cloud.

Exponential Backoff and Jitter

Retries will continue to use the backoff and jitter already used today.

Number of Retries

The default will be 5, which was the Pulp2 default.

User configuration

The Remote will get a new field:

retry_count = models.PositiveIntegerField(default=5)


Related issues

Has duplicate Pulp - Story #8873: pulp 3 stops when encounters 403 errorCLOSED - DUPLICATE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by ggainey 4 days ago

"configurable per-remote, w/a new Remote field" means a data-migration, which has impacts on backporting. I'd like to see the code w/a hardcoded 5 as one commit, and add the migration/check-per-remote to be a separate commit. Could be same PR, could even be different ones.

#2 Updated by dalley 4 days ago

I volunteer for this if I still have time whenever we decide it needs to be picked up.

#3 Updated by bmbouter 4 days ago

  • Description updated (diff)

#4 Updated by ipanova@redhat.com 2 days ago

  • Has duplicate Story #8873: pulp 3 stops when encounters 403 error added

#5 Updated by ipanova@redhat.com 2 days ago

I would suggest to lower the default value to 3. If we plan to retry on all the codes, I don't think retying, for example, on code 500 for 5 times is a good idea,with the default base and factor of the backoff.expo we will loose ~30 seconds.

#6 Updated by dalley about 22 hours ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley

#7 Updated by dalley about 9 hours ago

  • Status changed from ASSIGNED to POST

Please register to edit this issue

Also available in: Atom PDF