Project

Profile

Help

Story #8454

closed

As a user, I can't delete RepositoryVersion.number==0

Added by bmbouter over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 94
Quarter:

Description

Current State

You cannot delete version 0. That is enforced int the code here.

Proposal

Allow users to be able to delete RepoVersion 0 if it is not the only RepoVersion. Due to the set-differencing data model in Pulp, RepositoryVersions must have at least one RepositoryVerison.

Implementation

  1. The viewset should no longer prevent that RepositoryVersion 0 can be removed
  2. A check needs to be added to the Delete Task that if the RepositoryVersion being deleted is the only remaining repository version an error is raised
  3. Add tests (see below)

Add Tests

We need a functional test asserting the correctness around removing RepoVersion 0. Something like:

  1. Create a repository
  2. Put some content in it to create RepoVersion 1
  3. Put more content in it to create RepoVersion 2
  4. Assert the content counts for RepositoryVersion 2
  5. Assert the content summary data from RepoVersion 2
  6. Delete RepoVersion 0
  7. Delete RepoVersion 1
  8. Assert the content counts from RepoVersion 2 again, to ensure the content is still in-tact.
  9. Assert the content summary data from RepoVersion 2 again, to ensure it is correct

We also need a functional test asserting that the only remaining repository version cannot be deleted.

  1. Create a Repository
  2. Try to delete repository 0
  3. Assert the task fails.

Related issues

Blocks Pulp - Story #8368: Limit number of old repository versions.CLOSED - CURRENTRELEASEdaviddavis

Actions

Also available in: Atom PDF