As a user, I can't delete RepositoryVersion.number==0
You cannot delete version 0. That is enforced int the code here.
Allow users to be able to delete RepoVersion 0 if it is not the only RepoVersion. Due to the set-differencing data model in Pulp, RepositoryVersions must have at least one RepositoryVerison.
- The viewset should no longer prevent that RepositoryVersion 0 can be removed
- A check needs to be added to the Delete Task that if the RepositoryVersion being deleted is the only remaining repository version an error is raised
- Add tests (see below)
We need a functional test asserting the correctness around removing RepoVersion 0. Something like:
- Create a repository
- Put some content in it to create RepoVersion 1
- Put more content in it to create RepoVersion 2
- Assert the content counts for RepositoryVersion 2
- Assert the content summary data from RepoVersion 2
- Delete RepoVersion 0
- Delete RepoVersion 1
- Assert the content counts from RepoVersion 2 again, to ensure the content is still in-tact.
- Assert the content summary data from RepoVersion 2 again, to ensure it is correct
We also need a functional test asserting that the only remaining repository version cannot be deleted.
- Create a Repository
- Try to delete repository 0
- Assert the task fails.
#3 Updated by ggainey about 1 month ago
I know that at least some of our tests 'assume' that you will always get an answer from a URL like
/pulp/api/v3/repositories/rpm/rpm/UUID/versions/0/ . I wouldn't block the proposal to allow /0/ to be deleted as a result, but we'll want to look very carefully to see where else that assumption might have crept into the code.
Please register to edit this issue