Issue #7834
closedUpdated deprecation status is not included in sync
Description
This was seen on testing with galaxy_ng: In 4.2.0 GA, updated deprecation status is not sync’d from cloud to on-prem hub
Steps to recreate:
- Ensure the
synctest
repo in ci.cloud.redhat.com has some collections deprecated, others not - For the first time, sync the repo from cloud to on-prem hub
- Confirm deprecation status is as expected on each collection in on-prem hub
- Change deprecation status on one of the synced collections on cloud
- Sync again
- Observe that the collection on-prem does not have the deprecation status changed as expected
Updated by fao89 about 4 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 86
- Quarter set to Q4-2020
Updated by fao89 about 4 years ago
https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/models.py#L237-L265
https://github.com/pulp/pulpcore/blob/master/pulpcore/app/models/repository.py#L786-L820
If the deprecation was the only thing that changed from the last version, the new version will be deleted, therefore the deprecation status won't get updated
Updated by fao89 about 4 years ago
Test scenario:
-
sync
-
modify deprecation status from one collection
-
sync again
-
verify the deprecation corresponds with the remote source
-
verify a new repository version was created
Question: should deprecation status be synced only on mirror mode?
Updated by bmbouter about 4 years ago
The syncing in these examples: from where? Since we can only "set" deprecated on the local pulp system it would need to be a pulp-to-pulp sync, but I suspect these are from actual remote sources like galaxy.
I expected sync to occur on all sync types, mirror and otherwise.
Updated by bmbouter about 4 years ago
I think the current bug comes in because since Pulp has already saved the content locally and the changing of deprecated state info occurs at save time it ends up not updated the changed deprecated state for content it already saved into that repo. Basically it's a re-sync bug due to the setting of deprecated data being set only on newly saved units here.
Updated by fao89 about 4 years ago
the tests scenario I thought was not valid, since the deprecation is being changed locally, and for the reported issue it happens at server side
Updated by pulpbot about 4 years ago
- Status changed from NEW to POST
Added by Fabricio Aguiar about 4 years ago
Updated by Anonymous about 4 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_ansible|eae4deedcce89ee6c93752b0693cef21b51d2b46.
Updated by pulpbot about 4 years ago
Added by Fabricio Aguiar about 4 years ago
Revision a3e7827c | View on GitHub
Ensure deprecation status is synced even when no content changes
Updated by pulpbot about 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Ensure deprecation status is synced even when no content changes
https://pulp.plan.io/issues/7834 closes #7834