Issue #7834
closed
Updated deprecation status is not included in sync
Status:
CLOSED - CURRENTRELEASE
Description
This was seen on testing with galaxy_ng: In 4.2.0 GA, updated deprecation status is not sync’d from cloud to on-prem hub
Steps to recreate:
- Ensure the
synctest repo in ci.cloud.redhat.com has some collections deprecated, others not
- For the first time, sync the repo from cloud to on-prem hub
- Confirm deprecation status is as expected on each collection in on-prem hub
- Change deprecation status on one of the synced collections on cloud
- Sync again
- Observe that the collection on-prem does not have the deprecation status changed as expected
- Project changed from Pulp to Ansible Plugin
- Triaged changed from No to Yes
- Sprint set to Sprint 86
- Quarter set to Q4-2020
- Sprint/Milestone set to 0.5.2
Test scenario:
-
sync
-
modify deprecation status from one collection
-
sync again
-
verify the deprecation corresponds with the remote source
-
verify a new repository version was created
Question: should deprecation status be synced only on mirror mode?
The syncing in these examples: from where? Since we can only "set" deprecated on the local pulp system it would need to be a pulp-to-pulp sync, but I suspect these are from actual remote sources like galaxy.
I expected sync to occur on all sync types, mirror and otherwise.
I think the current bug comes in because since Pulp has already saved the content locally and the changing of deprecated state info occurs at save time it ends up not updated the changed deprecated state for content it already saved into that repo. Basically it's a re-sync bug due to the setting of deprecated data being set only on newly saved units here.
the tests scenario I thought was not valid, since the deprecation is being changed locally, and for the reported issue it happens at server side
- Status changed from NEW to POST
- Status changed from POST to MODIFIED
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Also available in: Atom
PDF
.
Ensure deprecation status is synced even when no content changes
https://pulp.plan.io/issues/7834 closes #7834