Project

Profile

Help

Issue #7834

closed

Updated deprecation status is not included in sync

Added by awcrosby about 2 years ago. Updated about 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
3. High
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 86
Quarter:
Q4-2020

Description

This was seen on testing with galaxy_ng: In 4.2.0 GA, updated deprecation status is not sync’d from cloud to on-prem hub

Steps to recreate:

  1. Ensure the synctest repo in ci.cloud.redhat.com has some collections deprecated, others not
  2. For the first time, sync the repo from cloud to on-prem hub
  3. Confirm deprecation status is as expected on each collection in on-prem hub
  4. Change deprecation status on one of the synced collections on cloud
  5. Sync again
  6. Observe that the collection on-prem does not have the deprecation status changed as expected
Actions #1

Updated by fao89 about 2 years ago

  • Project changed from Pulp to Ansible Plugin
Actions #2

Updated by fao89 about 2 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 86
  • Quarter set to Q4-2020
Actions #3

Updated by fao89 about 2 years ago

https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/models.py#L237-L265

https://github.com/pulp/pulpcore/blob/master/pulpcore/app/models/repository.py#L786-L820

If the deprecation was the only thing that changed from the last version, the new version will be deleted, therefore the deprecation status won't get updated

Actions #4

Updated by fao89 about 2 years ago

  • Sprint/Milestone set to 0.5.2
Actions #5

Updated by fao89 about 2 years ago

Test scenario:

  • sync

  • modify deprecation status from one collection

  • sync again

  • verify the deprecation corresponds with the remote source

  • verify a new repository version was created


Question: should deprecation status be synced only on mirror mode?

Actions #6

Updated by bmbouter about 2 years ago

The syncing in these examples: from where? Since we can only "set" deprecated on the local pulp system it would need to be a pulp-to-pulp sync, but I suspect these are from actual remote sources like galaxy.

I expected sync to occur on all sync types, mirror and otherwise.

Actions #7

Updated by bmbouter about 2 years ago

I think the current bug comes in because since Pulp has already saved the content locally and the changing of deprecated state info occurs at save time it ends up not updated the changed deprecated state for content it already saved into that repo. Basically it's a re-sync bug due to the setting of deprecated data being set only on newly saved units here.

Actions #8

Updated by fao89 about 2 years ago

the tests scenario I thought was not valid, since the deprecation is being changed locally, and for the reported issue it happens at server side

Actions #10

Updated by pulpbot about 2 years ago

  • Status changed from NEW to POST

Added by Fabricio Aguiar about 2 years ago

Revision eae4deed

Ensure deprecation status is synced even when no content changes

https://pulp.plan.io/issues/7834 closes #7834

Actions #11

Updated by Anonymous about 2 years ago

  • Status changed from POST to MODIFIED

Added by Fabricio Aguiar about 2 years ago

Revision a3e7827c

Ensure deprecation status is synced even when no content changes

https://pulp.plan.io/issues/7834 closes #7834

Actions #13

Updated by pulpbot about 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF