Story #5927: As a plugin writer, I can validate Content data in the Stages API - Pulp

Send by e-mail

Story #5927

As a plugin writer, I can validate Content data in the Stages API

Added by daviddavis about 2 months ago. Updated 4 days ago.

Status:

POST

Priority:

Normal

Assignee:

fabricio.aguiar

Category:

Sprint/Milestone:

3.2.0

Start date:

Due date:

% Done:

Platform Release:

Blocks Release:

Backwards Incompatible:

Groomed:

Yes

Sprint Candidate:

Yes

Tags:

QA Contact:

Complexity:

Smash Test:

Verified:

Verification Required:

Sprint:

Sprint 67

Description

In a discussion on pulp-dev[0] we decided that models shouldn't validate data (but rather serializers should). The Stages API should provide a way for plugin writers to validate Content data when syncing.

[0] https://www.redhat.com/archives/pulp-dev/2019-December/msg00003.html

History

#1 Updated by daviddavis about 2 months ago

Description updated (diff)

#2 Updated by bmbouter about 2 months ago

Groomed changed from No to Yes
Sprint Candidate changed from No to Yes

#3 Updated by rchan about 2 months ago

Sprint set to Sprint 64

#4 Updated by fabricio.aguiar about 1 month ago

Status changed from NEW to ASSIGNED
Assignee set to fabricio.aguiar

#5 Updated by fabricio.aguiar about 1 month ago

I have an implementation, but I made so many workarounds:
https://github.com/pulp/pulpcore/pull/514

1 - I adapted PulpPluginAppConfig for getting the serializers (2 serializers with the same model, results in dict with only the last serializer)
2 - Convert model to dict for using it on serializer
2.1 - serializers with nested serializers like DistributionTreeSerializer: https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/serializers.py#L1020
I'm sending an empty list on the related fields like: "addons": [], "checksums": [], ...
2.2 - SingleArtifactContentUploadSerializer needs relative_path, artifact / file, I'm sending a fake file,
but when validation requires a specific kind of file it fails. I got it here: https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/serializers.py#L232-L246
which I treated by avoiding deferred_validate
but I also got a problem here:
https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/serializers.py#L500-L513
that I could not treat