Issue #5425: User additions to /etc/pulp/settings.py can be unexpectedly overwritten - Pulp

Send by e-mail

Issue #5425

User additions to /etc/pulp/settings.py can be unexpectedly overwritten

Added by bmbouter over 1 year ago. Updated about 1 year ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 60

Quarter:

Description

As described here the current settings loader configuration of dynaconf loads settings in the wrong order. Specifically /etc/pulp/settings.py is loaded first which seems incorrect.

Where?¶

This all happens here: https://github.com/pulp/pulpcore/blob/master/pulpcore/app/settings.py#L221-L232

Solution¶

@rochabruno proposed we stop setting SETTINGS_MODULE_FOR_DYNACONF and move the /etc/pulp/settings.py to the end as shown here

Related issues

Associated revisions

Revision 4b2cdd92 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Load /etc/pulp/settings.py last when loading settings

fixes: #5425 https://pulp.plan.io/issues/5425

Revision 662299ff View on GitHub
Added by dkliban@redhat.com over 1 year ago

Use environment variable to set db username when running unittest

This updates the Travis config to the latest version of plugin_template.

re: #5425 https://pulp.plan.io/issues/5425

Revision 7d64b11c View on GitHub
Added by dkliban@redhat.com over 1 year ago

Use environment variable to set db username for unit test runs

re: #5425 https://pulp.plan.io/issues/5425

History

#1 Updated by daviddavis over 1 year ago

Sprint/Milestone set to 71

#2 Updated by fao89 over 1 year ago

Subject changed from As a user, I cannot provide settings that override defaults in pulpcore or plugins to User additions to /etc/pulp/settings.py can be unexpectedly overwritten
Triaged changed from No to Yes