Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #5425

closed

User additions to /etc/pulp/settings.py can be unexpectedly overwritten

Added by bmbouter almost 4 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
dkliban@redhat.com
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 60
Quarter:

Description

As described here the current settings loader configuration of dynaconf loads settings in the wrong order. Specifically /etc/pulp/settings.py is loaded first which seems incorrect.

Where?

This all happens here: https://github.com/pulp/pulpcore/blob/master/pulpcore/app/settings.py#L221-L232

Solution

@rochabruno proposed we stop setting SETTINGS_MODULE_FOR_DYNACONF and move the /etc/pulp/settings.py to the end as shown here

Related issues

Has duplicate Pulp - Issue #5547: Settings in /etc/pulp/settings.py has lower priority than settings provided by pluginsCLOSED - DUPLICATEActions
Actions
Copy link
 #1

Updated by daviddavis almost 4 years ago

  • Sprint/Milestone set to 71
Actions
Copy link
 #2

Updated by fao89 almost 4 years ago

  • Subject changed from As a user, I cannot provide settings that override defaults in pulpcore or plugins to User additions to /etc/pulp/settings.py can be unexpectedly overwritten
  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by bmbouter almost 4 years ago

  • Sprint/Milestone changed from 71 to 3.0.0
Actions
Copy link
 #4

Updated by ttereshc almost 4 years ago

  • Has duplicate Issue #5547: Settings in /etc/pulp/settings.py has lower priority than settings provided by plugins added
Actions
Copy link
 #5

Updated by dkliban@redhat.com almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com
Actions
Copy link
 #6

Updated by dkliban@redhat.com almost 4 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #7

Updated by dkliban@redhat.com almost 4 years ago

  • Sprint set to Sprint 60

Added by dkliban@redhat.com almost 4 years ago

Revision 4b2cdd92

Load /etc/pulp/settings.py last when loading settings

fixes: #5425 https://pulp.plan.io/issues/5425

Added by dkliban@redhat.com almost 4 years ago

Revision 662299ff

Use environment variable to set db username when running unittest

This updates the Travis config to the latest version of plugin_template.

re: #5425 https://pulp.plan.io/issues/5425

Added by dkliban@redhat.com almost 4 years ago

Revision 7d64b11c

Use environment variable to set db username for unit test runs

re: #5425 https://pulp.plan.io/issues/5425

Actions
Copy link
 #8

Updated by dkliban@redhat.com almost 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #9

Updated by bmbouter over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF