Issue #5425
User additions to /etc/pulp/settings.py can be unexpectedly overwritten
Description
As described here the current settings loader configuration of dynaconf loads settings in the wrong order. Specifically /etc/pulp/settings.py is loaded first which seems incorrect.
Where?¶
This all happens here: https://github.com/pulp/pulpcore/blob/master/pulpcore/app/settings.py#L221-L232
Solution¶
@rochabruno proposed we stop setting SETTINGS_MODULE_FOR_DYNACONF
and move the /etc/pulp/settings.py to the end as shown here
Related issues
Associated revisions
Revision 662299ff
View on GitHub
Use environment variable to set db username when running unittest
This updates the Travis config to the latest version of plugin_template.
Revision 7d64b11c
View on GitHub
Use environment variable to set db username for unit test runs
History
#1
Updated by daviddavis over 1 year ago
- Sprint/Milestone set to 71
#2
Updated by fao89 over 1 year ago
- Subject changed from As a user, I cannot provide settings that override defaults in pulpcore or plugins to User additions to /etc/pulp/settings.py can be unexpectedly overwritten
- Triaged changed from No to Yes
#3
Updated by bmbouter over 1 year ago
- Sprint/Milestone changed from 71 to 3.0.0
#4
Updated by ttereshc over 1 year ago
- Has duplicate Issue #5547: Settings in /etc/pulp/settings.py has lower priority than settings provided by plugins added
#5
Updated by dkliban@redhat.com over 1 year ago
- Status changed from NEW to ASSIGNED
- Assignee set to dkliban@redhat.com
#6
Updated by dkliban@redhat.com over 1 year ago
- Status changed from ASSIGNED to POST
#7
Updated by dkliban@redhat.com over 1 year ago
- Sprint set to Sprint 60
#8
Updated by dkliban@redhat.com over 1 year ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|4b2cdd9209aaa4974a256d5eaff4cb2a2f03b46d.
#9
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Load /etc/pulp/settings.py last when loading settings
fixes: #5425 https://pulp.plan.io/issues/5425