Project

Profile

Help

Issue #5425

User additions to /etc/pulp/settings.py can be unexpectedly overwritten

Added by bmbouter about 1 month ago. Updated 9 days ago.

Status:
MODIFIED
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 60

Description

As described here the current settings loader configuration of dynaconf loads settings in the wrong order. Specifically /etc/pulp/settings.py is loaded first which seems incorrect.

Where?

This all happens here: https://github.com/pulp/pulpcore/blob/master/pulpcore/app/settings.py#L221-L232

Solution

@rochabruno proposed we stop setting SETTINGS_MODULE_FOR_DYNACONF and move the /etc/pulp/settings.py to the end as shown here


Related issues

Duplicated by Pulp - Issue #5547: Settings in /etc/pulp/settings.py has lower priority than settings provided by plugins CLOSED - DUPLICATE Actions

Associated revisions

Revision 4b2cdd92 View on GitHub
Added by dkliban@redhat.com 9 days ago

Load /etc/pulp/settings.py last when loading settings

fixes: #5425
https://pulp.plan.io/issues/5425

Revision 662299ff View on GitHub
Added by dkliban@redhat.com 9 days ago

Use environment variable to set db username when running unittest

This updates the Travis config to the latest version of plugin_template.

re: #5425
https://pulp.plan.io/issues/5425

Revision 7d64b11c View on GitHub
Added by dkliban@redhat.com 9 days ago

Use environment variable to set db username for unit test runs

re: #5425
https://pulp.plan.io/issues/5425

History

#1 Updated by daviddavis about 1 month ago

  • Sprint/Milestone set to 71

#2 Updated by fabricio.aguiar about 1 month ago

  • Subject changed from As a user, I cannot provide settings that override defaults in pulpcore or plugins to User additions to /etc/pulp/settings.py can be unexpectedly overwritten
  • Triaged changed from No to Yes

#3 Updated by bmbouter about 1 month ago

  • Sprint/Milestone changed from 71 to 3.0

#4 Updated by ttereshc 10 days ago

  • Duplicated by Issue #5547: Settings in /etc/pulp/settings.py has lower priority than settings provided by plugins added

#5 Updated by dkliban@redhat.com 10 days ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com

#6 Updated by dkliban@redhat.com 10 days ago

  • Status changed from ASSIGNED to POST

#7 Updated by dkliban@redhat.com 10 days ago

  • Sprint set to Sprint 60

#8 Updated by dkliban@redhat.com 9 days ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF