Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4449

closed

Default to mirror = False

Added by dalley almost 6 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
ttereshc
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 49
Quarter:

Description

Syncing with mirror=True is a destructive operation, and it's especially destructive if you are storing multiple content types in the same repository. Since mirror mode doesn't respect plugin type boundaries [0], doing a mirror sync will wipe out any content in the repo that isn't of a type handled by plugin performing the sync.

Even with copious documented warnings which we don't yet have [1], I feel like this is a bad default value. The concern that repositories would accumulate too many old packages that are never cleaned is valid, but it's likely able to be solved in much less destructive ways than this.

This problem could also be resolved by making mirror mode respect type boundaries [0], but that seems architecturally difficult.

[0] https://pulp.plan.io/issues/3961
[1] https://pulp.plan.io/issues/4341

Related issues

Related to Pulp - Story #4341: As a user, I have comprehensive docs on mirroring, sync modes, and how they interact togetherCLOSED - CURRENTRELEASEamacdona@redhat.com

Actions
Related to Pulp - Test #4448: Test sync mirror=TrueCLOSED - COMPLETEragbalakActions
Actions
Copy link
 #1

Updated by dalley almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by dalley almost 6 years ago

  • Subject changed from Don't default to mirror=True to Default to mirror = False
Actions
Copy link
 #3

Updated by amacdona@redhat.com almost 6 years ago

+1. Even if mirror is the expected default for some plugins, I completely agree that we should err on the side of not being destructive.

Actions
Copy link
 #4

Updated by kersom almost 6 years ago

  • Related to Story #4341: As a user, I have comprehensive docs on mirroring, sync modes, and how they interact together added
Actions
Copy link
 #5

Updated by kersom almost 6 years ago

  • Related to Test #4448: Test sync mirror=True added
Actions
Copy link
 #6

Updated by CodeHeeler almost 6 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 49
  • Tags Pulp 3 RC Blocker added
Actions
Copy link
 #7

Updated by ttereshc almost 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc
Actions
Copy link
 #9

Updated by ttereshc almost 6 years ago

  • Status changed from POST to MODIFIED

Applied in changeset commit:pulpcore-plugin|1269464b1f335fbf81889d3551ec83d9c8458e67.

Actions
Copy link
 #10

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #11

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)
Actions
Copy link
 #12

Updated by bmbouter about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF