Issue #4437: Cannot adapt BaseUrl when serving Content at a custom URL using a custom aiohttp handler - Pulp

Actions

Send by e-mail Copy link

Issue #4437

closed

Cannot adapt BaseUrl when serving Content at a custom URL using a custom aiohttp handler

Added by bmbouter about 5 years ago. Updated over 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 49

Quarter:

Description

Problem¶

Assume that A plugin writer is adding custom routes to serve their content. They likely require this because they need more control when serving an Artifact, e.g. response headers. When their Distribution serializes the base_path it will serve all Pulp content at /pulp/content/. This is correct for most Content, but not for this type which serves it at a custom route in the content app, e.g. /mycustomurl/.

The Distributor Serializer/Viewset is also not part of the plugin API which prevents the reuse of that serializer/viewset.

This was originally identified by gmbnomis in this comment

Solution¶

Make the Serializer and Viewset part of the plugin API

Actions

Copy link

Updated by bmbouter about 5 years ago

Tags Pulp 3 RC Blocker added

I believe this will produce an API change so I believe it needs to be done before the RC.

Actions

Copy link

Updated by bmbouter about 5 years ago

gmbnomis the docker team told me they subclassed the Distribution object and implemented a different serializer for the BaseURL.

Actions

Copy link

Updated by bmbouter about 5 years ago

The DockerDistributionSerializer is here for examaple: https://github.com/pulp/pulp_docker/blob/master/pulp_docker/app/serializers.py#L199

DockerDistributionViewSet: https://github.com/pulp/pulp_docker/blob/master/pulp_docker/app/viewsets.py#L193-L205

Actions

Copy link

Updated by bmbouter about 5 years ago

gmbnomis do you want to go this subclassing route or try to reconfigure the URL on the BaseURL?

Actions

Copy link

Updated by jortel@redhat.com about 5 years ago

This seems to be the same as https://pulp.plan.io/issues/4391 but not enough detail written here to tell. Could someone add more detail to the description, please?

Actions

Copy link

Updated by bmbouter about 5 years ago

Description updated (diff)

I rewrote this with more detail. It's different than https://pulp.plan.io/issues/4391 which deals with the serialization of base_path in the common case.

Actions

Copy link