Project

Profile

Help

Refactor #4382

closed

Refactor ArtifactFileField

Added by daviddavis about 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 49
Quarter:

Description

Some problems with the ArtifactFileField pre_save:

- It's hard to read and understand what it's doing
- It's complex
- It calls super twice which seems strange

I spent some time trying to refactor it while working on S3 support but ultimately gave up. We should refactor this file and perhaps look at other ways to save Artifact files.

Also available in: Atom PDF