Project

Profile

Help

Refactor #4382

Refactor ArtifactFileField

Added by daviddavis over 2 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 49
Quarter:

Description

Some problems with the ArtifactFileField pre_save:

- It's hard to read and understand what it's doing
- It's complex
- It calls super twice which seems strange

I spent some time trying to refactor it while working on S3 support but ultimately gave up. We should refactor this file and perhaps look at other ways to save Artifact files.

Associated revisions

History

#1 Updated by dkliban@redhat.com over 2 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
  • Sprint set to Sprint 48

#2 Updated by rchan over 2 years ago

  • Sprint changed from Sprint 48 to Sprint 49

#3 Updated by ttereshc over 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc

#4 Updated by ttereshc over 2 years ago

  • Status changed from ASSIGNED to POST

#5 Updated by ttereshc over 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#6 Updated by daviddavis over 2 years ago

  • Sprint/Milestone set to 3.0.0

#7 Updated by bmbouter over 2 years ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)

#8 Updated by bmbouter almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF