RPM Support

ipanova@redhat.com wrote:

from publish part:
[...]

I suggest we explicitly first filter by module being available in the repo and based on result:
a) positive, continue with filtering by rpms being available in the repo
b) negative, to do not publish the collection at all( module name + packages)and do not proceed with filtering by rpms avaialable in the repo. We do not want to end up to publish in updateinfo.xml module which is not present in the repo, but for some reason rpms are present in the repo)

+1 makes sense; I'm updating the description accordingly

• if no rpms are found for/associated with an erratum but module information is specified, such erratum has to be published. It's possible that just module metadata changed and no rpms has been updated, e.g an rpm was removed from the artifacts to fix the module issue.

I guess we need to distinguish between a situation where all the RPMs were filtered out by the (module) repo presence and a genuine, metadata-only modular erratum; a consequence of neglect in the former case would be an unwanted, "empty" update on the consumer side.
The genuine, metadata-only erratum of a module might have to, in case of (modular) dependency updates, pull-in additional content into the repository to avoid dependency issues on the consumer side.

Probably we could address both these concerns by calculating implied dependencies of modular errata:

• publish should filter by module being available in the repo; modular errata rpms not attached to a module present in the repo should be excluded from publishing
• publish should continue filtering by rpms being available in the repo

• skip the module erratum publish altogether if there are unsatisfied (modular) dependencies in the repository

• if no rpms are found for/associated with an erratum but module information is specified, such erratum has to be published. It's possible that just module metadata changed and no rpms has been updated, e.g an rpm was removed from the artifacts to fix the module issue.

sync&publish PR: https://github.com/pulp/pulp_rpm/pull/1173

Just checked that the simple copy works OK

[vagrant@pulp2 pulp_rpm]$ http POST https://admin:admin@pulp2.dev/pulp/api/v2/repositor
ies/modulerr_copy/actions/associate/ source_repo_id=modulerr criteria:='{"type_ids": ["
erratum"], "filters": {"unit": {"errata_id": "RHEA-2018:0042"}}}'
HTTP/1.1 202 Accepted
Connection: Keep-Alive
Content-Length: 172
Content-Type: application/json; charset=utf-8
Date: Mon, 10 Sep 2018 15:30:43 GMT
Keep-Alive: timeout=5, max=10000
Server: Apache/2.4.33 (Fedora) OpenSSL/1.1.0h-fips mod_wsgi/4.5.15 Python/2.7

{
    "error": null,
    "result": null,
    "spawned_tasks": [
        {
            "_href": "/pulp/api/v2/tasks/e9e5b53c-ce69-465a-9f24-1a236964ca21/",
            "task_id": "e9e5b53c-ce69-465a-9f24-1a236964ca21"
        }
    ]
}

[vagrant@pulp2 pulp_rpm]$ http https://admin:admin@pulp2.dev/pulp/api/v2/tasks/e9e5b53c-ce69-465a-9f24-1a236964ca21/
HTTP/1.1 200 OK
Connection: Keep-Alive
Content-Length: 832
Content-Type: application/json; charset=utf-8
Date: Mon, 10 Sep 2018 15:31:01 GMT
ETag: "c75cc3612b1cbf4073d5602e0eab95ef"
Keep-Alive: timeout=5, max=10000
Server: Apache/2.4.33 (Fedora) OpenSSL/1.1.0h-fips mod_wsgi/4.5.15 Python/2.7

{
    "_href": "/pulp/api/v2/tasks/e9e5b53c-ce69-465a-9f24-1a236964ca21/",
    "_id": {
        "$oid": "5b968e237f513442b097f791"
    },
    "_ns": "task_status",
    "error": null,
    "exception": null,
    "finish_time": "2018-09-10T15:30:43Z",
    "id": "5b968e237f513442b097f791",
    "progress_report": {},
    "queue": "reserved_resource_worker-4@pulp2.dev.dq2",
    "result": {
        "units_failed_signature_filter": [],
        "units_successful": [
            {
                "type_id": "erratum",
                "unit_key": {
                    "id": "RHEA-2018:0042"
                }
            }
        ]
    },
    "spawned_tasks": [],
    "start_time": "2018-09-10T15:30:43Z",
    "state": "finished",
    "tags": [
        "pulp:repository:modulerr_copy",
        "pulp:repository:modulerr",
        "pulp:action:associate"
    ],
    "task_id": "e9e5b53c-ce69-465a-9f24-1a236964ca21",
    "task_type": "pulp.server.managers.repo.unit_association.associate_from_repo",
    "traceback": null,
    "worker_name": "reserved_resource_worker-4@pulp2.dev"
}

[vagrant@pulp2 pulp_rpm]$

Double checking Mongo:

> db.repo_content_units.findOne({"repo_id": "modulerr_copy", "unit_type_id": "erratum"})
{
        "_id" : ObjectId("5b966c0c7f513442b096c9e7"),
        "repo_id" : "modulerr_copy",
        "unit_id" : "01f04ca4-0788-4e1c-84e8-9b2f21efab1f",
        "unit_type_id" : "erratum",
        "updated" : "2018-09-10T15:39:05Z",
        "created" : "2018-09-10T13:05:16Z"
}
> db.units_erratum.findOne({"_id": "01f04ca4-0788-4e1c-84e8-9b2f21efab1f"})
{
        "_id" : "01f04ca4-0788-4e1c-84e8-9b2f21efab1f",
        "pulp_user_metadata" : {

        },
        "_last_updated" : 1536332456,
        "errata_id" : "RHEA-2018:0042",
        "status" : "stable",
        "updated" : "2018-09-05 11:23:42",
        "description" : "Walrus Erratum; metadata-only",
        "issued" : "2002-02-20 00:22:00",
        "pushcount" : "1",
        "references" : [ ],
        "reboot_suggested" : false,
        "relogin_suggested" : false,
        "restart_suggested" : false,
        "from" : "betelgeuze",
        "version" : "1",
        "release" : "1",
        "type" : "enhancement",
        "pkglist" : [ ],
        "title" : "Walrus",
        "_ns" : "units_erratum",
        "_content_type_id" : "erratum"
}
>

Pulp issue: https://github.com/PulpQE/Pulp-2-Tests/issues/94

Applied in changeset 7bb8f8813bde09760635fdaa30eb049800d2b652.

This feature was already automated. See Pulp 2 Test Case

We already have automation in place for this one. ManageModularErrataTestCase