Project

Profile

Help

Issue #1394

closed

export distributor does not allow 'relative_url' config override

Added by cduryee almost 9 years ago. Updated over 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

The yum export distributor uses the ExportRepoPublisher to perform an export. This supports a 'relative_url' config option which is extremely useful since setting the relative_url will create delicious listing files, whereas setting the 'export_dir' alone will not.

However, the export distributor's config checker does not think 'relative_url' is a valid configuration key. This patch seems to do the trick, and allows 'relative_url' to be set on the exporter:

--- /tmp/constants.py.old       2015-12-02 17:19:18.509000000 -0500
+++ /usr/lib/python2.7/site-packages/pulp_rpm/common/constants.py       2015-12-02 15:58:30.320000000 -0500
@@ -134,9 +134,10 @@
 SKIP_KEYWORD = 'skip'
 START_DATE_KEYWORD = 'start_date'
 GENERATE_SQLITE_KEYWORD = 'generate_sqlite'
+RELATIVE_URL_KEYWORD = 'relative_url'
 EXPORT_OPTIONAL_CONFIG_KEYS = (END_DATE_KEYWORD, ISO_PREFIX_KEYWORD, SKIP_KEYWORD,
                                EXPORT_DIRECTORY_KEYWORD, START_DATE_KEYWORD, ISO_SIZE_KEYWORD,
-                               GENERATE_SQLITE_KEYWORD)
+                               GENERATE_SQLITE_KEYWORD, RELATIVE_URL_KEYWORD)

 EXPORT_HTTP_DIR = '/var/lib/pulp/published/http/exports/repo'
 EXPORT_HTTPS_DIR = '/var/lib/pulp/published/https/exports/repo'

Can this be fixed in the next Pulp release? It would help me out immensely since I can then rely on Pulp to create exports with listing files :)


Related issues

Blocks RPM Support - Story #1419: As a pulp-admin user, I can set relative-url on the export distributorCLOSED - CURRENTRELEASEsemyers

Actions

Also available in: Atom PDF