Project

Profile

Help

Story #1419

As a pulp-admin user, I can set relative-url on the export distributor

Added by semyers almost 5 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.8.0
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Support for relative-url in the export distributor config should come with #1394, but adding support for that to pulp-admin is a little tricky, warranting a brief discussion of the options:

Option 1:
Currently[0], --relative-url isn't passed into the export distributor config when repos are created or updated. If it was passed into the export distributor, it would probably result in a backward-incompatible change, since it will change the published repo path on the next publish and probably break anything depending on the location of that repo.

Option 2:
Breaking backward compatibility is an option if we want this for 3.0, but the safer option might be to add another flag just for the export distributer to the repo create/update command, e.g. --export-relative-url.

Option 3:
The export run command[1] supports its own config flags as runtime overrides, so --relative-url could be added to only that command, but this is a portentially crappy user experience (Why do I have to set relative-url again?) so again the --export-relative-url might be the flag to use.

Option 4 (my preference):
Some combination of options 1 and 2, and option 3: probably add --export-relative-url to repo create/update and also to export run, maintaining backward compatibility the whole way.

Option 5:
Do nothing. The option is in the docs, leave it to adventurous users to modify the export distributor config via the REST API.

Option 6:
Something I didn't think of.

I think this becomes a relatively easy task once an option is chosen.

[0]: https://github.com/pulp/pulp_rpm/blob/c95bf5af25173abce724261cdef5bb5509e613e0/extensions_admin/pulp_rpm/extensions/admin/repo_create_update.py
[1]: https://github.com/pulp/pulp_rpm/blob/c95bf5af25173abce724261cdef5bb5509e613e0/extensions_admin/pulp_rpm/extensions/admin/export.py


Related issues

Blocked by RPM Support - Issue #1394: export distributor does not allow 'relative_url' config overrideCLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision fb945b1c View on GitHub
Added by semyers over 4 years ago

Add export distributer relative URL support to pulp-admin

Also fixes a tiny doc bug that slipped through in a previous commit

https://pulp.plan.io/issues/1419 fixes #1419

History

#1 Updated by semyers almost 5 years ago

  • Blocked by Issue #1394: export distributor does not allow 'relative_url' config override added

#2 Updated by semyers over 4 years ago

After some consideration, option 3 (only add support for relative-url on the export command) is the winner. There is already precedent for not specifying export distributor options in the repo create/update step, so just adding --relative-url support to the export step, very much the same way that --export-dir does, is a simple option with no backward-incompatibility issues. Option 5 (use the REST interface) also still works really well.

#3 Updated by semyers over 4 years ago

  • Status changed from NEW to POST
  • Assignee set to semyers
  • Platform Release set to 2.8.0

#4 Updated by semyers over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by rbarlow over 4 years ago

  • Status changed from MODIFIED to 5

#6 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#7 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF