Issue #8656: Remove external call from 0061_call_handle_artifact_checksums_command - Pulp

Actions

Send by e-mail Copy link

Issue #8656

closed

Remove external call from 0061_call_handle_artifact_checksums_command

Added by osapryki almost 3 years ago. Updated almost 3 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

daviddavis

Category:

Sprint/Milestone:

3.13.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 97

Quarter:

Description

Calling management command from migrations eventually leads to breaking the migration tree in new installations, once the models used in handle-artifact-checksums go out of sync with schema valid during application of this particular migration.

Migrations must not depend on models neither directly nor indirectly (through management commands).

Possible workaround would be to replace calling management command in the migration with noop.

Actions

Copy link

Updated by fao89 almost 3 years ago

Triaged changed from No to Yes
Sprint set to Sprint 95

Actions

Copy link

Updated by rchan almost 3 years ago

Sprint changed from Sprint 95 to Sprint 96

Actions

Copy link

Updated by daviddavis almost 3 years ago

Sprint/Milestone set to 3.13.0

Actions

Copy link

Updated by bmbouter almost 3 years ago

From the pulpcore meeting today, we're going to ensure the code used in the migration will only use code that constructs models from the db.

Was that the only issue you saw here? I had heard that there was an error experienced at upgrade time but I don't see the details here.

Using a noop is not a reasonable option because then the pulp installer, pulp containers, katello installer, individual users, galaxy-ng, etc, etc would all have to handle this manually. This is was the reason it's in the migrations to start with.

Actions

Copy link