Project

Profile

Help

Issue #8656

closed

Remove external call from 0061_call_handle_artifact_checksums_command

Added by osapryki over 1 year ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 97
Quarter:

Description

Calling management command from migrations eventually leads to breaking the migration tree in new installations, once the models used in handle-artifact-checksums go out of sync with schema valid during application of this particular migration.

Migrations must not depend on models neither directly nor indirectly (through management commands).

Possible workaround would be to replace calling management command in the migration with noop.

Actions #1

Updated by fao89 over 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 95
Actions #2

Updated by rchan over 1 year ago

  • Sprint changed from Sprint 95 to Sprint 96
Actions #3

Updated by daviddavis over 1 year ago

  • Sprint/Milestone set to 3.13.0
Actions #4

Updated by bmbouter over 1 year ago

From the pulpcore meeting today, we're going to ensure the code used in the migration will only use code that constructs models from the db.

Was that the only issue you saw here? I had heard that there was an error experienced at upgrade time but I don't see the details here.

Using a noop is not a reasonable option because then the pulp installer, pulp containers, katello installer, individual users, galaxy-ng, etc, etc would all have to handle this manually. This is was the reason it's in the migrations to start with.

Actions #5

Updated by daviddavis over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions #6

Updated by pulpbot over 1 year ago

  • Status changed from ASSIGNED to POST
Actions #7

Updated by rchan over 1 year ago

  • Sprint changed from Sprint 96 to Sprint 97

Added by daviddavis over 1 year ago

Revision 20fa101a

Change migration to use django's get_model

fixes #8656

Actions #8

Updated by daviddavis over 1 year ago

  • Status changed from POST to MODIFIED
Actions #9

Updated by pulpbot over 1 year ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF