Project

Profile

Help

Issue #8656

Remove external call from 0061_call_handle_artifact_checksums_command

Added by osapryki 6 months ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 97
Quarter:

Description

Calling management command from migrations eventually leads to breaking the migration tree in new installations, once the models used in handle-artifact-checksums go out of sync with schema valid during application of this particular migration.

Migrations must not depend on models neither directly nor indirectly (through management commands).

Possible workaround would be to replace calling management command in the migration with noop.

Associated revisions

Revision 20fa101a View on GitHub
Added by daviddavis 5 months ago

Change migration to use django's get_model

fixes #8656

History

#1 Updated by fao89 6 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 95

#2 Updated by rchan 6 months ago

  • Sprint changed from Sprint 95 to Sprint 96

#3 Updated by daviddavis 5 months ago

  • Sprint/Milestone set to 3.13.0

#4 Updated by bmbouter 5 months ago

From the pulpcore meeting today, we're going to ensure the code used in the migration will only use code that constructs models from the db.

Was that the only issue you saw here? I had heard that there was an error experienced at upgrade time but I don't see the details here.

Using a noop is not a reasonable option because then the pulp installer, pulp containers, katello installer, individual users, galaxy-ng, etc, etc would all have to handle this manually. This is was the reason it's in the migrations to start with.

#5 Updated by daviddavis 5 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#6 Updated by pulpbot 5 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by rchan 5 months ago

  • Sprint changed from Sprint 96 to Sprint 97

#8 Updated by daviddavis 5 months ago

  • Status changed from POST to MODIFIED

#9 Updated by pulpbot 5 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF