Project

Profile

Help

Backport #8367

closed

Backpot to 2.2: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type header

Added by ipanova@redhat.com over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Triaged:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 92
Quarter:


Related issues

Copied from Container Support - Backport #8366: Backpot to 2.1: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type headerCLOSED - CURRENTRELEASEmdellweg

Actions
Actions #1

Updated by ipanova@redhat.com over 3 years ago

  • Copied from Backport #8366: Backpot to 2.1: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type header added
Actions #2

Updated by mdellweg over 3 years ago

  • Assignee changed from dkliban@redhat.com to mdellweg
Actions #3

Updated by ipanova@redhat.com over 3 years ago

  • Status changed from NEW to ASSIGNED
  • Sprint changed from Sprint 90 to Sprint 92
Actions #4

Updated by pulpbot over 3 years ago

  • Status changed from ASSIGNED to POST

Added by dkliban@redhat.com over 3 years ago

Revision 4825d7a4 | View on GitHub

Handle HEAD requests as if they are GET requests

The Content-Type header is stripped by DRF when there is no body in the response.

Django and aiohttp both strip the body of HEAD requests. It is safe to handle HEAD requests the same as GET requests and rely on the web server to strip the body of the response.

This patch also adds the Content-Type header to the ManifestResponse objects which are used when responding to requests of Manifest creation.

fixes: #8367 https://pulp.plan.io/issues/8367

backports: #8208 https://pulp.plan.io/issues/8208 (cherry picked from commit ceb266c7cb8fefc2efb49ff7cfa9311480d6044a)

Added by dkliban@redhat.com over 3 years ago

Revision 4825d7a4 | View on GitHub

Handle HEAD requests as if they are GET requests

The Content-Type header is stripped by DRF when there is no body in the response.

Django and aiohttp both strip the body of HEAD requests. It is safe to handle HEAD requests the same as GET requests and rely on the web server to strip the body of the response.

This patch also adds the Content-Type header to the ManifestResponse objects which are used when responding to requests of Manifest creation.

fixes: #8367 https://pulp.plan.io/issues/8367

backports: #8208 https://pulp.plan.io/issues/8208 (cherry picked from commit ceb266c7cb8fefc2efb49ff7cfa9311480d6044a)

Actions #5

Updated by dkliban@redhat.com over 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #6

Updated by pulpbot over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF