Project

Profile

Help

Backport #8366

Backpot to 2.1: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type header

Added by ipanova@redhat.com 8 months ago. Updated 8 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Triaged:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 92
Quarter:


Related issues

Copied from Container Support - Issue #8208: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type headerCLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Copied to Container Support - Backport #8367: Backpot to 2.2: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type headerCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision d0fee9ed View on GitHub
Added by dkliban@redhat.com 8 months ago

Handle HEAD requests as if they are GET requests

The Content-Type header is stripped by DRF when there is no body in the response.

Django and aiohttp both strip the body of HEAD requests. It is safe to handle HEAD requests the same as GET requests and rely on the web server to strip the body of the response.

This patch also adds the Content-Type header to the ManifestResponse objects which are used when responding to requests of Manifest creation.

fixes #8366 https://pulp.plan.io/issues/8366

backports #8208 https://pulp.plan.io/issues/8208

(cherry picked from commit ceb266c7cb8fefc2efb49ff7cfa9311480d6044a)

Revision d0fee9ed View on GitHub
Added by dkliban@redhat.com 8 months ago

Handle HEAD requests as if they are GET requests

The Content-Type header is stripped by DRF when there is no body in the response.

Django and aiohttp both strip the body of HEAD requests. It is safe to handle HEAD requests the same as GET requests and rely on the web server to strip the body of the response.

This patch also adds the Content-Type header to the ManifestResponse objects which are used when responding to requests of Manifest creation.

fixes #8366 https://pulp.plan.io/issues/8366

backports #8208 https://pulp.plan.io/issues/8208

(cherry picked from commit ceb266c7cb8fefc2efb49ff7cfa9311480d6044a)

History

#1 Updated by ipanova@redhat.com 8 months ago

  • Copied from Issue #8208: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type header added

#2 Updated by ipanova@redhat.com 8 months ago

  • Copied to Backport #8367: Backpot to 2.2: docker 20.10 client pull operation fails with Error response from daemon: missing or empty Content-Type header added

#3 Updated by mdellweg 8 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee changed from dkliban@redhat.com to mdellweg

#4 Updated by pulpbot 8 months ago

  • Status changed from ASSIGNED to POST

#5 Updated by dkliban@redhat.com 8 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#6 Updated by mdellweg 8 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#7 Updated by ipanova@redhat.com 8 months ago

  • Sprint changed from Sprint 90 to Sprint 92

Please register to edit this issue

Also available in: Atom PDF