Story #8205: Add AnsibleCollectionDeprecated resource to export/import - Ansible Plugin - Pulp

Actions

Send by e-mail Copy link

Story #8205

closed

Add AnsibleCollectionDeprecated resource to export/import

Added by gerrod about 3 years ago. Updated over 2 years ago.

Status:

MODIFIED

Priority:

Normal

Assignee:

fao89

Sprint/Milestone:

0.10.0

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Sprint Candidate:

Tags:

Katello

Sprint:

Quarter:

Description

The Two Related Problem¶

The 'deprecated' data is mutable.
The 'deprecated' data is not correctly included in import/export data

Solution¶

From a high level, make the AnsibleCollectionDeprecated content.

Modeling¶

Here are the rough steps involved:

switch the existing AnsibleCollectionDeprecated to inherit from Content
Remove the repository_version FK entirely.
Change the collection field to be a string with the collection name instead
Add a string field called namespace.
The uniqueness constraint should be the tuple "namespace", "collection_name"

Sync Implementation¶

The sync code will continue to parse the deprecated data in FirstStage in the same way, but instead of saving/managing them in first-stage, have the stages pipeline handle it all by making AnsibleCollectionDeprecated in-memory and associating with a declarative content object.

The Galaxy API viewset¶

Port this portion to look for the objects in the set of content of the RepositoryVersion.

The viewset for set/unset deprecation handling¶

Port this portion to generate a task that creates a RepositoryVersion

Additional work needed to get this working with Import/Export¶

Add a model to model resources: https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/modelresource.py

Related issues

Actions

Copy link

Updated by gerrod about 3 years ago

Blocked by Task #8204: Add method to allow import of models with references to repo versions added

Actions

Copy link

Updated by bmbouter about 3 years ago

Tags Katello added

Actions

Copy link

Updated by fao89 about 3 years ago

Sprint/Milestone set to 1.0.0 - Candidates

Actions

Copy link

Updated by bmbouter almost 3 years ago

Tracker changed from Task to Story
Description updated (diff)

Actions

Copy link

Updated by daviddavis almost 3 years ago

Change the collection field to be a string with the collection name instead

I'm assuming this will contain namespace? Or we have to add another field for namespace?

Additional work needed to get this working with Import/Export

We just need to add a model to model resources: https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/modelresource.py

Actions

Copy link

Updated by bmbouter almost 3 years ago

Description updated (diff)

I put the import/export work in the ticket body.

We've talked with galaxy_ng about them moving the model over too but right now I was hoping to just store it as a string. I put that into the modelling details too.

Actions

Copy link

Updated by fao89 almost 3 years ago

Status changed from NEW to ASSIGNED
Assignee set to fao89

Actions

Copy link

Updated by fao89 almost 3 years ago

the first issue I found is the data migration, AnsibleCollectionDeprecated as content would change the repository versions.

AnsibleCollectionDeprecated(
    collection=Collection(name="pulp_installer", namespace="pulp"), 
    repository_version=RepositoryVersion(number=1),
)

AnsibleCollectionDeprecated(
    name="pulp_installer", 
    namespace="pulp",
) 
+ RepositoryContent

Actions

Copy link

Updated by bmbouter almost 3 years ago

I don't understand the issue with AnsibleCollectionDeprecated and migrations. Are you saying that changing the AnsibleCollectionDeprecated model will break the migrations?

Actions

Copy link

#10