Project

Profile

Help

Issue #7907

Failed task did not clean up properly resource reservations

Added by osapryki 5 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 86
Quarter:

Description

In Automation Hub the task galaxy_ng.app.tasks.synclist.curate_synclist_repository failed due to redis failure. However resource reservation for that task remained in the database blocking entire tasking system (if workers number = 1).

https://gist.github.com/cutwater/4ec7960f0eac2793ca17a78723dca75d

Environment:

pulpcore 3.7.1

pulp-ansible 0.4.3

galaxy-ng 1326eb5f1679880b68e05a48d4377def7c72a95b

Workers number: 1

Analysis

After review, the failure scenario goes like this:

  1. The tasking code itself runs to completion
  2. RQ attempts to notify Redis the task is completed (in the RQ registry) in its (handle_job_success)[https://github.com/rq/rq/blob/master/rq/worker.py#L925].
  3. Interacting with Redis raised an exception at this line: https://github.com/rq/rq/blob/master/rq/worker.py#L932
  4. This fatal exception raised and handled by Pulp's handle_job_failure handler implementation which records the exception (how we know this) and also marks the task as failed
  5. Also when Redis became unavailable, it forgot the tasks it was storing in memory which includes the _release_resources that pairs with the now failed task and is intended to release the locks
  6. The worker never died so other lock cleanup processes never occurred.
  7. Tasks backup and eventually a sysadmin restarts the processes
  8. The cleanup code in mark_worker_offline is triggered, but since the task is already at FAILED, this line does not issue it's cancellation which would release the locks
  9. The locks are never released....

Solution

Add in code to mark_worker_offline that will ensure all locks for a worker being cleaned up are released even if the a task failed and its _release_resources was never delivered. This should occur after the cancellation for all tasks in "completed" states.


Related issues

Related to Pulp - Issue #7386: Task that does not exist in worker or resource-manager are never cleaned upNEW<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Pulp - Backport #7951: Backport 7907CLOSED - WONTFIX

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 516df314 View on GitHub
Added by bmbouter 5 months ago

Adds additional lock cleanup to worker cleanup

As another layer of security to guard against lock cleanup not occurring due to Redis not delivering the _release_resource task, ensure all locks are also cleaned up even for tasks that are in their final states.

closes #7907

History

#1 Updated by fao89 5 months ago

  • Related to Issue #7386: Task that does not exist in worker or resource-manager are never cleaned up added

#2 Updated by fao89 5 months ago

  • Priority changed from Normal to High
  • Triaged changed from No to Yes

#3 Updated by bmbouter 5 months ago

  • Subject changed from Failed curate_synclist_repository task did not clean up properly resource reservations to Failed task did not clean up properly resource reservations
  • Description updated (diff)

#4 Updated by bmbouter 5 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter

#5 Updated by dkliban@redhat.com 5 months ago

  • Sprint set to Sprint 86

#6 Updated by pulpbot 5 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by bmbouter 5 months ago

  • Status changed from POST to MODIFIED

#8 Updated by daviddavis 4 months ago

  • Sprint/Milestone set to 3.9.0

#9 Updated by pulpbot 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#10 Updated by daviddavis 4 months ago

Please register to edit this issue

Also available in: Atom PDF