Project

Profile

Help

Issue #7741

closed

Code doesn't handle requirements.yml sources with different api versions

Added by daviddavis almost 2 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

From what I gather from the code, it doesn't seem to handle that sources in requirements.yml may have different api versions. It just uses the api version from the remote.url:

https://github.com/pulp/pulp_ansible/blob/739a5551c87f4fffa9f46bee7fce9975e39020e8/pulp_ansible/app/tasks/collections.py#L359


Related issues

Related to Ansible Plugin - Refactor #7777: As a developer I want collections sync machinery easier to maintainCLOSED - CURRENTRELEASEbmbouter

Actions
Actions #1

Updated by fao89 almost 2 years ago

  • Parent task set to #7777
Actions #2

Updated by fao89 almost 2 years ago

  • Parent task deleted (#7777)
Actions #3

Updated by fao89 almost 2 years ago

  • Related to Refactor #7777: As a developer I want collections sync machinery easier to maintain added
Actions #4

Updated by bmbouter almost 2 years ago

  • Status changed from NEW to POST
  • Assignee set to bmbouter

Added by bmbouter almost 2 years ago

Revision 2ab95bd8

Refactors sync to use asyncio more and many tests

The previous sync machinery design was very complicated due to treating the asynchronous coroutines as synchronous code. This rewrites the sync code to have the coroutines track the work instead.

In doing the rewrite several bugs were fixed also:

  • versions in requirements.yml are now respected
  • requirements.yml with different sources are now respected too

It also makes many test improvements:

  • refactors Galaxy V2 sync tests to be bindings based
  • adds may more tests

closes #7739 closes #7741 closes #7777

Actions #5

Updated by bmbouter almost 2 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by fao89 almost 2 years ago

  • Sprint/Milestone set to 0.6.0
Actions #7

Updated by fao89 almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF