Project

Profile

Help

Issue #7741

Code doesn't handle requirements.yml sources with different api versions

Added by daviddavis 11 months ago. Updated 10 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

From what I gather from the code, it doesn't seem to handle that sources in requirements.yml may have different api versions. It just uses the api version from the remote.url:

https://github.com/pulp/pulp_ansible/blob/739a5551c87f4fffa9f46bee7fce9975e39020e8/pulp_ansible/app/tasks/collections.py#L359


Related issues

Related to Ansible Plugin - Refactor #7777: As a developer I want collections sync machinery easier to maintainCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 2ab95bd8 View on GitHub
Added by bmbouter 10 months ago

Refactors sync to use asyncio more and many tests

The previous sync machinery design was very complicated due to treating the asynchronous coroutines as synchronous code. This rewrites the sync code to have the coroutines track the work instead.

In doing the rewrite several bugs were fixed also:

  • versions in requirements.yml are now respected
  • requirements.yml with different sources are now respected too

It also makes many test improvements:

  • refactors Galaxy V2 sync tests to be bindings based
  • adds may more tests

closes #7739 closes #7741 closes #7777

History

#1 Updated by fao89 11 months ago

  • Parent task set to #7777

#2 Updated by fao89 11 months ago

  • Parent task deleted (#7777)

#3 Updated by fao89 11 months ago

  • Related to Refactor #7777: As a developer I want collections sync machinery easier to maintain added

#4 Updated by bmbouter 10 months ago

  • Status changed from NEW to POST
  • Assignee set to bmbouter

#5 Updated by bmbouter 10 months ago

  • Status changed from POST to MODIFIED

#6 Updated by fao89 10 months ago

  • Sprint/Milestone set to 0.6.0

#7 Updated by fao89 10 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF