Project

Profile

Help

Issue #7291

Advisory merge incorrectly reuses UpdateCollections

Added by ggainey about 2 months ago. Updated about 1 month ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 79
Quarter:

Description

When combining content to make a new repository-version, there is a specific edge-case that results in an advisory that exists in both places to be merged into a single new advisory. In this case, current pulp_rpm code "reuses" the UpdateCollections from the previous advisory in such a way that they 'belong to' both the previous and the newly-merged/created advisory.

This is a different usage-pattern than that used for any other sub-object of an advisory. It also prevents us from linking an UpdateCollection directly (and only) to its 'owning' advisory, which is desirable for a number of reasons (see #5740 and #7195 for examples)

We need to:

  • teach merge_advisories() to make a deep copy of the 'previous_advisory' collections and their packages
  • point the new copies at the new advisory
  • build a data-migration to find and fix existing instances of an UpdateCollection being linked to multiple advisories

Associated revisions

Revision 192a9035 View on GitHub
Added by ggainey about 2 months ago

Teach merge_advisory() to use its own copies of relevant UpdateCollections.

Added migration to clean up and data that is already in this broken state.

fixes #7291 [nocoverage]

History

#1 Updated by ttereshc about 2 months ago

  • Description updated (diff)
  • Triaged changed from No to Yes
  • Sprint set to Sprint 78

#2 Updated by pulpbot about 2 months ago

  • Status changed from ASSIGNED to POST

#3 Updated by rchan about 2 months ago

  • Sprint changed from Sprint 78 to Sprint 79

#4 Updated by ggainey about 2 months ago

  • Status changed from POST to MODIFIED

#5 Updated by ttereshc about 1 month ago

  • Sprint/Milestone set to 3.6.0

#6 Updated by pulpbot about 1 month ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF