Project

Profile

Help

Story #5740

As a user, advisory collection names are unique within an advisory

Added by ttereshc 11 months ago. Updated 2 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 78
Quarter:

Description

Background

As a part of #4295, two advisories can be merged into a new one which contains combined package list.

Motivation

Each package list consists of collections (usually 1 , but can be 0 or 2+ as well). Each collection has a name which is expected to be unique by dnf/yum client. If the name is not unique, only a subset of packages will be updated when advisory is applied on a user system.

Solution

Ensure the uniqueness of collection names at the time of combining two advisories into one.
If names are unique, preserve original names.
If names are the same, make them unique (e.g. append an ordinal number to the existing name)

Associated revisions

Revision 18e6fed9 View on GitHub
Added by ggainey 3 months ago

Teach advisory-merge to avoid package-collection name collisions.

Closes a hole in a very specific edge case in advisory-merge during a copy operation. Requires two advisories that have:

  • same id
  • same update-date
  • package-collections with the same name
    • whose package-lists do NOT intersect

Changes one sych collection's name to insure name-uniqueness.

Also, fixed a test_retention test to stop failing due to postgres non-determinism.

closes #5740 [nocoverage]

History

#1 Updated by ttereshc 8 months ago

  • Sprint/Milestone set to Priority items (outside of planned milestones/releases)

#2 Updated by ggainey 3 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ggainey
  • Sprint set to Sprint 78

#3 Updated by pulpbot 3 months ago

  • Status changed from ASSIGNED to POST

#4 Updated by ggainey 3 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by ttereshc 2 months ago

  • Sprint/Milestone changed from Priority items (outside of planned milestones/releases) to 3.6.0

#6 Updated by pulpbot 2 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF