Issue #6910
closedCannot use a source-checkout of a plugin without also having a source checkout of pulpcore
Description
Goal¶
I would like to develop a plugin but not pulpcore. To do that I would likely have my local.dev-config.yml
be:
# Options
pulp_devel_supplement_bashrc: true
pulp_default_admin_password: password
pulp_install_plugins:
# pulp-ansible:
# source_dir: "/home/vagrant/devel/pulp_ansible"
# galaxy-ng:
# source_dir: "/home/vagrant/devel/galaxy_ng"
# pulp-certguard:
# source_dir: "/home/vagrant/devel/pulp-certguard"
# pulp-cookbook:
# source_dir: "/home/vagrant/devel/pulp_cookbook"
# pulp-deb:
# source_dir: "/home/vagrant/devel/pulp_deb"
# pulp-container:
# source_dir: "/home/vagrant/devel/pulp_container"
# pulp-gem:
# source_dir: "/home/vagrant/devel/pulp_gem"
# pulp-maven:
# source_dir: "/home/vagrant/devel/pulp_maven"
# pulp-python:
# source_dir: "/home/vagrant/devel/pulp_python"
# pulp-rpm:
# source_dir: "/home/vagrant/devel/pulp_rpm"
# # You can specify a folderpath to pulp.pulp_rpm_prerequisites instead of
# # just uncommenting this role name, but note that it is a path on the
# # pulplift host, not the guest VM like all the other paths.
# prereq_role: "pulp.pulp_rpm_prerequisites"
pulp-file:
source_dir: "/home/vagrant/devel/pulp_file"
# Vagrant source install Required
# pulp_webserver_server: "apache"
pulp_user: "vagrant"
developer_user: "vagrant"
developer_user_home: "/home/vagrant"
# pulp_source_dir: "/home/vagrant/devel/pulpcore"
pulp_settings:
secret_key: "unsafe_default"
content_origin: "http://{{ ansible_fqdn }}"
Notice especially that I've commented out pulp_settings
.
Error¶
If you use ^ playbook, you'll get an error like:
TASK [pulp_devel : Install requirements for building docs] *********************
fatal: [pulp3-source-fedora30]: FAILED! => {}
MSG:
The task includes an option with an undefined variable. The error was: 'pulp_source_dir' is undefined
The error appears to be in '/home/bmbouter/devel/pulp3/pulplift/pulp_installer/roles/pulp_devel/tasks/install_docs_requirements.yml': line 2, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
---
- name: Install requirements for building docs
^ here
What's strange is that the "installing pulpcore from pypi" seems to work but fails at a later step.
Updated by dkliban@redhat.com about 4 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 74
Updated by mdepaulo@redhat.com about 4 years ago
This should be quick & easy to implement:
pulp_devel/defaults/main.yml
has:
pulp_requirements_dir: "{{ pulp_source_dir }}"
And then pulp_requirements_dir is used for 3 tasks, including the one listed above.
Those tasks should only be called when
pulp_source_dir is defined, or if pulp_requirements_dir is non-zero-length.
(Perhaps even eliminate pulp_requirements_dir and use pulp_source_dir directly.)
Updated by fao89 about 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to fao89
Updated by pulpbot about 4 years ago
- Status changed from ASSIGNED to POST
Added by Fabricio Aguiar about 4 years ago
Added by Fabricio Aguiar about 4 years ago
Revision 4aee9fc6 | View on GitHub
Devel role not requiring to set pulp_source_dir
Updated by Anonymous about 4 years ago
- Status changed from POST to MODIFIED
Applied in changeset ansible-pulp|4aee9fc60e6ba1caca2cf3d872faffb9e22a7fcb.
Updated by Anonymous about 4 years ago
Applied in changeset ansible-pulp3|4aee9fc60e6ba1caca2cf3d872faffb9e22a7fcb.
Updated by fao89 about 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Devel role not requiring to set pulp_source_dir
https://pulp.plan.io/issues/6910 closes #6910