Project

Profile

Help

Task #6772

closed

Collection Import needs to validate data with CollectionSerializer before saving

Added by bmbouter over 4 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Background

pulpcore recommends all plugin writers validate data with the corresponding serializer before saving with this issue.

pulp_ansible creates CollectionVersion objects from data returned by ansible-lint here. Notice that the CollectionVersionSerializer is never used to validate the model prior to saving.

Solution

Use the CollectionVersionSerializer to validate the model data before saving.

Actions #1

Updated by fao89 over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89

Added by Fabricio Aguiar over 4 years ago

Revision 013744b3 | View on GitHub

Serializer to validate collections while importing

https://pulp.plan.io/issues/6772 closes #6772

Actions #2

Updated by pulpbot over 4 years ago

  • Status changed from ASSIGNED to POST
Actions #3

Updated by Anonymous over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #4

Updated by fao89 over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #5

Updated by fao89 over 4 years ago

  • Sprint/Milestone set to 0.2.0

Also available in: Atom PDF