Actions
Issue #6697
closed
pulp_installer doesn't add a newline char in requirements.in
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
3.3.1
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 73
Quarter:
Description
A user on pulp-list reported the following during upgrade to 3.3.1:
After remove entire pulp installation directory. Now I am getting an error
fatal: [pulp3-2]: FAILED! => {"changed": false, "cmd": ["/opt/utils/venv/pulp/3.7.3/bin/pip-compile"], "delta": "0:00:00.778728", "end": "2020-05-08 17:26:32.680701", "failed_when_result": true, "msg": "non-zero return code", "rc": 2, "start": "2020-05-08 17:26:31.901973", "stderr": "Could not find a version that matches pulp-rpm-clientpulp-file-client (from -r requirements.in (line 6))\nNo versions found\nWas https://artifactory.inf.bloomberg.com/artifactory/api/pypi/bloomberg-pypi-ose/simple reachable?", "stderr_lines": ["Could not find a version that matches pulp-rpm-clientpulp-file-client (from -r requirements.in (line 6))", "No versions found", "Was https://artifactory.inf.bloomberg.com/artifactory/api/pypi/bloomberg-pypi-ose/simple reachable?"], "stdout": "", "stdout_lines": []}
It looks like this file is wrong
# more /opt/utils/venv/pulp/3.7.3/requirements.in
pulpcore==3.3.1
pulp-file==0.3.0
pulp-rpm==3.3.1
# Any plugins listed below were already installed but not specified in
# pulp_install_plugins
pulp-rpm-clientpulp-file-client
Updated by dkliban@redhat.com almost 4 years ago
- Version set to 3.3.1
- Tags Pulp 3 installer added
Updated by fao89 almost 4 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 72
Updated by dkliban@redhat.com almost 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to dkliban@redhat.com
Updated by dkliban@redhat.com almost 4 years ago
We most likely need to remove the '-' from this line here[0].
[0] https://github.com/pulp/pulp_installer/blob/master/roles/pulp/templates/requirements.in.j2#L11
Updated by dkliban@redhat.com almost 4 years ago
- Status changed from ASSIGNED to NEW
- Assignee deleted (
dkliban@redhat.com)
Updated by bmbouter almost 4 years ago
- Category set to Installer - Moved to GitHub issues
- Tags deleted (
Pulp 3 installer)
Updated by fao89 almost 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to fao89
Added by Fabricio Aguiar almost 4 years ago
Added by Fabricio Aguiar almost 4 years ago
Revision f2e28cbd | View on GitHub
Enforce new lines on requirements.in
Before:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-clientpulp-file-clientpulp-npmpulp-npm-clientpulp-rpm-clientpulp-smash
After:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-client
pulp-file-client
pulp-npm
pulp-npm-client
pulp-rpm-client
pulp-smash
Updated by fao89 almost 4 years ago
- Status changed from ASSIGNED to POST
Updated by pulpbot almost 4 years ago
Updated by Anonymous almost 4 years ago
- Status changed from POST to MODIFIED
Applied in changeset ansible-pulp|f2e28cbd0f8bb6764c929f05e971d9cd42f99f7c.
Added by Fabricio Aguiar almost 4 years ago
Revision f2bef07d | View on GitHub
Enforce new lines on requirements.in
Before:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-clientpulp-file-clientpulp-npmpulp-npm-clientpulp-rpm-clientpulp-smash
After:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-client
pulp-file-client
pulp-npm
pulp-npm-client
pulp-rpm-client
pulp-smash
Updated by Anonymous almost 4 years ago
Applied in changeset ansible-pulp|f2bef07d91b4f90a7c7ca378fbccdffd67305f82.
Added by Fabricio Aguiar almost 4 years ago
Revision 2571c5c7 | View on GitHub
Enforce new lines on requirements.in
Before:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-clientpulp-file-clientpulp-npmpulp-npm-clientpulp-rpm-clientpulp-smash
After:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-client
pulp-file-client
pulp-npm
pulp-npm-client
pulp-rpm-client
pulp-smash
Added by Fabricio Aguiar almost 4 years ago
Revision 2571c5c7 | View on GitHub
Enforce new lines on requirements.in
Before:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-clientpulp-file-clientpulp-npmpulp-npm-clientpulp-rpm-clientpulp-smash
After:
[vagrant@pulp3-source-fedora31 ~]$ cat /usr/local/lib/pulp/requirements.in
pulpcore==3.3.1
pulp-ansible
pulp-rpm
pulp-file
pulp-ansible-client
pulp-file-client
pulp-npm
pulp-npm-client
pulp-rpm-client
pulp-smash
Updated by Anonymous almost 4 years ago
Applied in changeset ansible-pulp|2571c5c7a51424a8b63dd4212229112c1e766084.
Updated by fao89 almost 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
.
Enforce new lines on requirements.in
Before:
After:
https://pulp.plan.io/issues/6697 closes #6697