Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #6510

closed

v3.serializers.CollectionVersionSerializer needs to include distro base_path in 'download_url'

Added by alikins over 4 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
fao89
Sprint/Milestone:
0.2.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 73
Quarter:

Description

v3.serializers.CollectionVersionSerializer doesn't include distro base_path in the 'download_url' it creates.

At the moment, since there is only one AnsibleRepository and one AnsibleDistribution, this doesn't cause a problem. But once we have multiple repositories, the 'download_url' will need to include the AnsibleDistribution.base_path in the url.

For example, with the galaxy_ng pr at https://github.com/ansible/galaxy_ng/pull/84/ it is possible to use per distro api endpoints.

For now, pr #84 has a local CollectionVersionSerializer that adds base_path to the 'download_url' so the 'download_url' looks like:

"http://localhost:24816/pulp/content/alikins-stage-distro-base-path/alikins.collection_inspect.0.0.182.tar.gz",

That will allow galaxy_ng to provide download_urls for 'golden' distro artifacts and for other repos/distros.

Actions
Copy link
 #1

Updated by sivel over 4 years ago

The construction should also likely utilize ANSIBLE_CONTENT_HOSTNAME instead of CONTENT_ORIGIN like v2.views. GalaxyCollectionVersionDetail

Part of the problem is that CONTENT_ORIGIN isn't supposed to have a scheme according to the advice I have been given.

Actions
Copy link
 #2

Updated by fao89 over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
  • Sprint set to Sprint 73
Actions
Copy link
 #3

Updated by pulpbot over 4 years ago

  • Status changed from ASSIGNED to POST

Added by Fabricio Aguiar over 4 years ago

Revision 8b01f6ad | View on GitHub

Updating v3 CollectionVersion download URL

https://pulp.plan.io/issues/6510 closes #6510

Actions
Copy link
 #4

Updated by Anonymous over 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #5

Updated by fao89 over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Copy link
 #6

Updated by fao89 over 4 years ago

  • Sprint/Milestone set to 0.2.0
Actions
Send by e-mail Copy link

Also available in: Atom PDF