v3.serializers.CollectionVersionSerializer needs to include distro base_path in 'download_url'
v3.serializers.CollectionVersionSerializer doesn't include distro base_path in the 'download_url' it creates.
At the moment, since there is only one AnsibleRepository and one AnsibleDistribution, this doesn't cause a problem. But once we have multiple repositories, the 'download_url' will need to include the AnsibleDistribution.base_path in the url.
For example, with the galaxy_ng pr at https://github.com/ansible/galaxy_ng/pull/84/ it is possible to use per distro api endpoints.
For now, pr #84 has a local CollectionVersionSerializer that adds base_path to the 'download_url' so the 'download_url' looks like:
That will allow galaxy_ng to provide download_urls for 'golden' distro artifacts and for other repos/distros.
Updated by sivel over 3 years ago
The construction should also likely utilize ANSIBLE_CONTENT_HOSTNAME instead of CONTENT_ORIGIN like v2.views. GalaxyCollectionVersionDetail
Part of the problem is that CONTENT_ORIGIN isn't supposed to have a scheme according to the advice I have been given.
Updated by Anonymous over 3 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_ansible|8b01f6ad1f4e6ffa76839a255ce004b1b6eff52f.