Issue #6239
closed
pulp_ansible returns 404 for import status URL with trailing slash
Description
Currently ansible-galaxy waits for the publish step to complete by polling the URL 'http://host/api/v2/collection-imports/taskid' and on Galaxy that automatically redirects to 'http://host/api/v2/collection-imports/taskid/'. To save on the cost of redirection for a URL we call potentially multiple times and consistency with the Automation Hub API (and other Galaxy calls we make) we are now connecting to the trailing slash URL straight away. Pulp returns a 404 for this URL and should be fixed to act like Galaxy and Automation Hub
This change is being made in the PR https://github.com/ansible/ansible/pull/67685/files#diff-ebc3a9dba57fd6902f70f421dcd4957eR481.
Updated by jborean over 4 years ago
Without known the code I would guess that https://github.com/pulp/pulp_ansible/blob/593012370ed7313c8c561c2c8a9fdff5fcd3def1/pulp_ansible/app/urls.py#L35 just need to have a '/' added onto the end but we would need to make sure that means it's redirected for existing ansible-galaxy clients out there with the original URL code.
Updated by bmbouter over 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bmbouter
- Sprint set to Sprint 67
Adding to sprint so we can be compatible with the optimization from @jborean
Added by bmbouter over 4 years ago
Updated by bmbouter over 4 years ago
- Status changed from ASSIGNED to MODIFIED
Applied in changeset pulp_ansible|257ac0b9eab5f359fed92e3a20de2bf56cb6d202.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Fix ansible-galaxy CLI issue with 2.10.0
A trailing slash is needed so a new optimization in the CLI will still allow uploads to work. Existing 2.9.0 clients will also stay working with this change.
https://pulp.plan.io/issues/6239 closes #6239