Project

Profile

Help

Issue #6239

closed

pulp_ansible returns 404 for import status URL with trailing slash

Added by jborean almost 3 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 67
Quarter:

Description

Currently ansible-galaxy waits for the publish step to complete by polling the URL 'http://host/api/v2/collection-imports/taskid' and on Galaxy that automatically redirects to 'http://host/api/v2/collection-imports/taskid/'. To save on the cost of redirection for a URL we call potentially multiple times and consistency with the Automation Hub API (and other Galaxy calls we make) we are now connecting to the trailing slash URL straight away. Pulp returns a 404 for this URL and should be fixed to act like Galaxy and Automation Hub

This change is being made in the PR https://github.com/ansible/ansible/pull/67685/files#diff-ebc3a9dba57fd6902f70f421dcd4957eR481.

Actions #1

Updated by jborean almost 3 years ago

Without known the code I would guess that https://github.com/pulp/pulp_ansible/blob/593012370ed7313c8c561c2c8a9fdff5fcd3def1/pulp_ansible/app/urls.py#L35 just need to have a '/' added onto the end but we would need to make sure that means it's redirected for existing ansible-galaxy clients out there with the original URL code.

Actions #2

Updated by bmbouter almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
  • Sprint set to Sprint 67

Adding to sprint so we can be compatible with the optimization from @jborean

Added by bmbouter almost 3 years ago

Revision 257ac0b9

Fix ansible-galaxy CLI issue with 2.10.0

A trailing slash is needed so a new optimization in the CLI will still allow uploads to work. Existing 2.9.0 clients will also stay working with this change.

https://pulp.plan.io/issues/6239 closes #6239

Actions #3

Updated by bmbouter almost 3 years ago

  • Status changed from ASSIGNED to MODIFIED
Actions #4

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #5

Updated by fao89 over 2 years ago

  • Sprint/Milestone set to 0.2.0

Also available in: Atom PDF