Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #6077

closed

A wrong logical operator used in the method for validation of a signing script

Added by lmjachky almost 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
lmjachky
Category:
-
Sprint/Milestone:
3.1.1
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 66
Quarter:

Description

In the commit https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848, there was introduced an interface for a signing service.

When an administrator is trying to save a signing script to the database, Pulp performs additional checks whether the signing script is valid or not. On the line https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848#diff-5308662d441ee7c5774295277cba139cR433, however, there is an invalid logical operator used for validating a trust level. Instead of the 'and' operator, there should be used 'or'.

Actions
Send by e-mail Copy link

Also available in: Atom PDF